Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 939483003: Keep the declaration of FPDF_HasXFAField consistent with other XFA APIs (Closed)

Created:
5 years, 10 months ago by jun_fang
Modified:
5 years, 9 months ago
Reviewers:
Tom Sepez, kai_jing
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Keep the declaration of FPDF_HasXFAField consistent with other XFA APIs It's an enhancement requested in issue 452794. BUG=433994 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e118ce99c52a21a1093badc9d180539a9a6e973f

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -36 lines) Patch
M fpdfsdk/include/fpdfformfill.h View 2 chunks +14 lines, -0 lines 0 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_util.h View 1 chunk +0 lines, -6 lines 0 comments Download
M fpdfsdk/src/fpdfsave.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 2 1 chunk +30 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_util.cpp View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jun_fang
Hi Tom, please review this code change.
5 years, 10 months ago (2015-02-17 22:10:09 UTC) #2
Tom Sepez
LGTM once you fix the one comment. https://codereview.chromium.org/939483003/diff/1/fpdfsdk/src/fpdfview.cpp File fpdfsdk/src/fpdfview.cpp (right): https://codereview.chromium.org/939483003/diff/1/fpdfsdk/src/fpdfview.cpp#newcode327 fpdfsdk/src/fpdfview.cpp:327: FX_BOOL bDymasticXFA ...
5 years, 10 months ago (2015-02-17 22:16:34 UTC) #3
Tom Sepez
https://codereview.chromium.org/939483003/diff/20001/fpdfsdk/src/fpdfview.cpp File fpdfsdk/src/fpdfview.cpp (right): https://codereview.chromium.org/939483003/diff/20001/fpdfsdk/src/fpdfview.cpp#newcode323 fpdfsdk/src/fpdfview.cpp:323: FX_BOOL bDynamicXFA = FALSE; nit: assigning this to false ...
5 years, 10 months ago (2015-02-17 22:34:29 UTC) #5
jun_fang
5 years, 10 months ago (2015-02-17 22:53:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
e118ce99c52a21a1093badc9d180539a9a6e973f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698