Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: cc/blink/web_display_item_list_impl.cc

Issue 939463003: Resolve FIXMEs in cc for Display Item Lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed location offset. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/blink/web_display_item_list_impl.cc
diff --git a/cc/blink/web_display_item_list_impl.cc b/cc/blink/web_display_item_list_impl.cc
index 1b6f91acda7ae86608983fb52877b1efc33eef82..4941afe506232d591fe49246f932d242aa41ceaf 100644
--- a/cc/blink/web_display_item_list_impl.cc
+++ b/cc/blink/web_display_item_list_impl.cc
@@ -35,14 +35,7 @@ scoped_refptr<cc::DisplayItemList> WebDisplayItemListImpl::ToDisplayItemList() {
void WebDisplayItemListImpl::appendDrawingItem(const SkPicture* picture) {
display_item_list_->AppendItem(cc::DrawingDisplayItem::Create(
- skia::SharePtr(const_cast<SkPicture*>(picture)), gfx::PointF(0, 0)));
-}
-
-void WebDisplayItemListImpl::appendDrawingItem(
- SkPicture* picture,
- const blink::WebFloatPoint& location) {
- display_item_list_->AppendItem(
- cc::DrawingDisplayItem::Create(skia::SharePtr(picture), location));
+ skia::SharePtr(const_cast<SkPicture*>(picture))));
}
void WebDisplayItemListImpl::appendClipItem(
@@ -114,6 +107,18 @@ void WebDisplayItemListImpl::appendEndFilterItem() {
display_item_list_->AppendItem(cc::EndFilterDisplayItem::Create());
}
+void WebDisplayItemListImpl::appendScrollItem(
+ const blink::WebSize& scrollOffset,
+ ScrollContainerId) {
+ SkMatrix44 matrix;
+ matrix.setTranslate(-scrollOffset.width, -scrollOffset.height, 0);
+ appendTransformItem(matrix);
+}
+
+void WebDisplayItemListImpl::appendEndScrollItem() {
+ appendEndTransformItem();
+}
+
WebDisplayItemListImpl::~WebDisplayItemListImpl() {
}

Powered by Google App Engine
This is Rietveld 408576698