Resolve FIXMEs in cc for Display Item Lists.

Resolve FIXMEs in cc for Display Item Lists.

This is the final patch for removing location and making
SkPicture const in drawing display items, and the first patch
in adding scroll display item support in cc.

R=ajuma@chromium.org
BUG=458240
Committed: https://crrev.com/ba47b3ebc5d0b50ac44673774a66fe82f0dc8a21
Cr-Commit-Position: refs/heads/master@{#317060}

[Stephen Chennney, 2015-02-17 22:20:45]

The ongoing effort to fix the FIXMEs.

[ajuma, 2015-02-17 22:43:30]

https://codereview.chromium.org/939463003/diff/1/cc/resources/drawing_display...
File cc/resources/drawing_display_item.cc (right):

https://codereview.chromium.org/939463003/diff/1/cc/resources/drawing_display...
cc/resources/drawing_display_item.cc:30:
canvas->translate(picture_->cullRect().x(), picture_->cullRect().y());
Since location_ is currently being set to (0, 0), it seems like this will run
into the same problem as the previous CL, where this will apply a translation
that wasn't being applied previously. Is there going to be a Blink-side change
that will effectively inverse-translate?

[Stephen Chennney, 2015-02-18 18:30:54]

On 2015/02/17 22:43:30, ajuma wrote:
>
https://codereview.chromium.org/939463003/diff/1/cc/resources/drawing_display...
> File cc/resources/drawing_display_item.cc (right):
> 
>
https://codereview.chromium.org/939463003/diff/1/cc/resources/drawing_display...
> cc/resources/drawing_display_item.cc:30:
> canvas->translate(picture_->cullRect().x(), picture_->cullRect().y());
> Since location_ is currently being set to (0, 0), it seems like this will run
> into the same problem as the previous CL, where this will apply a translation
> that wasn't being applied previously. Is there going to be a Blink-side change
> that will effectively inverse-translate?

Yeah, it's busted. Should have run layout tests before bothering you, sorry.

[Stephen Chennney, 2015-02-19 15:36:52]

I think this is good now. Passes layout tests and cc_unittests.

https://codereview.chromium.org/939463003/diff/1/cc/resources/drawing_display...
File cc/resources/drawing_display_item.cc (right):

https://codereview.chromium.org/939463003/diff/1/cc/resources/drawing_display...
cc/resources/drawing_display_item.cc:30:
canvas->translate(picture_->cullRect().x(), picture_->cullRect().y());
On 2015/02/17 22:43:30, ajuma wrote:
> Since location_ is currently being set to (0, 0), it seems like this will run
> into the same problem as the previous CL, where this will apply a translation
> that wasn't being applied previously. Is there going to be a Blink-side change
> that will effectively inverse-translate?

Done. The unit test needed updating to match.

[ajuma, 2015-02-19 15:45:19]

lgtm

[Stephen Chennney, 2015-02-19 15:58:58]

The CQ bit was checked by schenney@chromium.org

[commit-bot: I haz the power, 2015-02-19 15:59:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/939463003/20001

[commit-bot: I haz the power, 2015-02-19 16:48:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-19 16:49:24]

Patchset 2 (id:??) landed as
https://crrev.com/ba47b3ebc5d0b50ac44673774a66fe82f0dc8a21
Cr-Commit-Position: refs/heads/master@{#317060}

[danakj, 2015-10-30 22:11:31]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-10-30 22:11:31]

https://codereview.chromium.org/939463003/diff/20001/cc/resources/drawing_dis...
File cc/resources/drawing_display_item.cc (right):

https://codereview.chromium.org/939463003/diff/20001/cc/resources/drawing_dis...
cc/resources/drawing_display_item.cc:67: base::StringPrintf("[%f,%f,%f,%f]",
picture_->cullRect().x(),
This appears to break tracing, I get a js error about this "Rect" not having 4
values. 

That sounds weird. But if I change this to
BeginArray()/SetInteger()x4/EndArray() that error goes away. (tracing is still
busted though for other reasons D:)