extensions/renderer/resources/guest_view/guest_view_container.js - Issue 939443002: Fixed guestview sizing bug that resulted in incorrect <webview> sizing on the signin page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/guest_view_container.js

Issue 939443002: Fixed guestview sizing bug that resulted in incorrect <webview> sizing on the signin page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/resources/guest_view/guest_view_container.js

diff --git a/extensions/renderer/resources/guest_view/guest_view_container.js b/extensions/renderer/resources/guest_view/guest_view_container.js

index ad555e7ce89380ed6f696ba6b6c7e7b6a152a273..0107a7e9bc7881a0a8c11ff2ebbbcaabc58be943 100644

--- a/extensions/renderer/resources/guest_view/guest_view_container.js

+++ b/extensions/renderer/resources/guest_view/guest_view_container.js

@@ -115,8 +115,9 @@ GuestViewContainer.prototype.handleBrowserPluginAttributeMutation =

GuestViewContainer.prototype.buildParams = function() {

var params = this.buildContainerParams();

params['instanceId'] = this.viewInstanceId;

- params['elementWidth'] = parseInt(this.element.offsetWidth);

- params['elementHeight'] = parseInt(this.element.offsetHeight);

+ var elementRect = this.element.getBoundingClientRect();

+ params['elementWidth'] = parseInt(elementRect.width);

+ params['elementHeight'] = parseInt(elementRect.height);

return params;

};

« no previous file with comments | « extensions/browser/guest_view/guest_view_base.cc ('k') | no next file » | no next file with comments »