Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: extensions/browser/guest_view/guest_view_base.h

Issue 939443002: Fixed guestview sizing bug that resulted in incorrect <webview> sizing on the signin page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view_base.h
diff --git a/extensions/browser/guest_view/guest_view_base.h b/extensions/browser/guest_view/guest_view_base.h
index ef3d8559e86bd92a999279ece850098989901f44..ddfa5c6c35b809b9fd85a015f6926d427a70eb5e 100644
--- a/extensions/browser/guest_view/guest_view_base.h
+++ b/extensions/browser/guest_view/guest_view_base.h
@@ -340,6 +340,17 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
void DispatchOnResizeEvent(const gfx::Size& old_size,
const gfx::Size& new_size);
+ // Get the zoom factor for the embedder's web contents.
+ double GetEmbedderZoomFactor();
+
+ // Convert sizes in pixles between logical and physical numbers of pixels.
Fady Samuel 2015/02/17 21:53:51 nit: s/pixles/pixels Split these two up and have
paulmeyer 2015/02/18 13:37:36 Done.
+ // Note that a size can consist of a fractional number of logical pixels
+ // (hence |logical_pixels| is represented as a double), but will always
+ // consist of an integral number of physical pixels (hence |physical_pixels|
+ // is represented as an int).
+ int LogicalPixelsToPhysicalPixels(double logical_pixels);
+ double PhysicalPixelsToLogicalPixels(int physical_pixels);
+
void SetUpSizing(const base::DictionaryValue& params);
void StartTrackingEmbedderZoomLevel();
« no previous file with comments | « no previous file | extensions/browser/guest_view/guest_view_base.cc » ('j') | extensions/browser/guest_view/guest_view_base.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698