Fixed guestview sizing bug that resulted in incorrect <webview> sizing on the signin page.

Fixed guestview sizing bug that resulted in incorrect <webview> sizing on the signin page.

The problem was that when the guestview (in this case, a webview) was initially sized, this size was incorrectly specified in logical pixels rather than physical pixels. When zoom is at 100%, these pixels are the same, but when zoomed, they are not. This resulted in the webview being too small when zoomed in and too large when zoomed out.

The fix involved converting the logical pixels to physical pixels (based on the page's zoom factor) for the guestview's initial sizing.

BUG=453221
Committed: https://crrev.com/1451fda11e2e0615d38505f0588a59856bb8be51
Cr-Commit-Position: refs/heads/master@{#316820}

[paulmeyer, 2015-02-17 21:46:37]

paulmeyer@chromium.org changed reviewers:
+ fsamuel@chromium.org

[paulmeyer, 2015-02-17 21:46:37]

+fsamuel@

[Fady Samuel, 2015-02-17 21:53:51]

lgtm + nits

https://codereview.chromium.org/939443002/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/guest_view_base.cc (right):

https://codereview.chromium.org/939443002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/guest_view_base.cc:722: return 1;
nit: return 1.0;

https://codereview.chromium.org/939443002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/guest_view_base.cc:727: return 1;
nit: return 1.0

https://codereview.chromium.org/939443002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/guest_view_base.cc:763: double element_height = 0;
nit: 0.0

https://codereview.chromium.org/939443002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/guest_view_base.cc:764: double element_width = 0;
nit: 0.0

https://codereview.chromium.org/939443002/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/guest_view_base.h (right):

https://codereview.chromium.org/939443002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/guest_view_base.h:346: // Convert sizes in pixles
between logical and physical numbers of pixels.
nit: s/pixles/pixels

Split these two up and have comments for each.

[paulmeyer, 2015-02-18 13:36:51]

New patchsets have been uploaded after l-g-t-m from fsamuel@chromium.org

[paulmeyer, 2015-02-18 13:37:32]

The CQ bit was checked by paulmeyer@chromium.org

[paulmeyer, 2015-02-18 13:37:36]

https://codereview.chromium.org/939443002/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/guest_view_base.cc (right):

https://codereview.chromium.org/939443002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/guest_view_base.cc:722: return 1;
On 2015/02/17 21:53:50, Fady Samuel wrote:
> nit: return 1.0;

Done.

https://codereview.chromium.org/939443002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/guest_view_base.cc:727: return 1;
On 2015/02/17 21:53:50, Fady Samuel wrote:
> nit: return 1.0

Done.

https://codereview.chromium.org/939443002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/guest_view_base.cc:763: double element_height = 0;
On 2015/02/17 21:53:50, Fady Samuel wrote:
> nit: 0.0

Done.

https://codereview.chromium.org/939443002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/guest_view_base.cc:764: double element_width = 0;
On 2015/02/17 21:53:50, Fady Samuel wrote:
> nit: 0.0

Done.

https://codereview.chromium.org/939443002/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/guest_view_base.h (right):

https://codereview.chromium.org/939443002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/guest_view_base.h:346: // Convert sizes in pixles
between logical and physical numbers of pixels.
On 2015/02/17 21:53:51, Fady Samuel wrote:
> nit: s/pixles/pixels
> 
> Split these two up and have comments for each.

Done.

[commit-bot: I haz the power, 2015-02-18 13:38:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/939443002/20001

[commit-bot: I haz the power, 2015-02-18 14:30:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-18 14:31:20]

Patchset 2 (id:??) landed as
https://crrev.com/1451fda11e2e0615d38505f0588a59856bb8be51
Cr-Commit-Position: refs/heads/master@{#316820}