Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 939393002: Add new string for "Open original image" feature. (Closed)

Created:
5 years, 10 months ago by Not at Google. Contact bengr
Modified:
5 years, 10 months ago
CC:
chromium-reviews, jamarante, pparmanand_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new string for "Open original image" feature. Feature is implemented in cl https://codereview.chromium.org/944533002/. Checking in user visible string separately so that it is in time for translation. BUG=456247 Committed: https://crrev.com/aa09b25c7ebcb64c6236ba4e559b3cd295089b91 Cr-Commit-Position: refs/heads/master@{#317361}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added '_' to string name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Not at Google. Contact bengr
5 years, 10 months ago (2015-02-20 00:08:12 UTC) #2
Not at Google. Contact bengr
5 years, 10 months ago (2015-02-20 00:11:19 UTC) #3
bengr
https://codereview.chromium.org/939393002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/939393002/diff/1/chrome/app/generated_resources.grd#newcode770 chrome/app/generated_resources.grd:770: + <message name="IDS_CONTENT_CONTEXT_OPENORIGINALIMAGENEWTAB" desc="The name of the Open Original ...
5 years, 10 months ago (2015-02-20 01:21:15 UTC) #4
Not at Google. Contact bengr
https://codereview.chromium.org/939393002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/939393002/diff/1/chrome/app/generated_resources.grd#newcode770 chrome/app/generated_resources.grd:770: + <message name="IDS_CONTENT_CONTEXT_OPENORIGINALIMAGENEWTAB" desc="The name of the Open Original ...
5 years, 10 months ago (2015-02-20 16:41:20 UTC) #5
bengr
On 2015/02/20 16:41:20, kundaji wrote: > https://codereview.chromium.org/939393002/diff/1/chrome/app/generated_resources.grd > File chrome/app/generated_resources.grd (right): > > https://codereview.chromium.org/939393002/diff/1/chrome/app/generated_resources.grd#newcode770 > ...
5 years, 10 months ago (2015-02-20 17:27:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939393002/20001
5 years, 10 months ago (2015-02-20 18:27:39 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-20 18:49:40 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 18:50:22 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa09b25c7ebcb64c6236ba4e559b3cd295089b91
Cr-Commit-Position: refs/heads/master@{#317361}

Powered by Google App Engine
This is Rietveld 408576698