Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 939303004: Remove stale comment about Node::insertBefore and friends (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 10 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove stale comment about Node::insertBefore and friends It was added in 2006 <https://trac.webkit.org/changeset/12568>; and was accurate at the time. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/core/dom/Node.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
PTAL
5 years, 10 months ago (2015-02-24 06:21:10 UTC) #2
philipj_slow
Ignore the semicolon in the description, it's not actually there, must be a Rietveld issue.
5 years, 10 months ago (2015-02-24 06:21:43 UTC) #3
Jens Widell
LGTM
5 years, 10 months ago (2015-02-24 06:22:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939303004/1
5 years, 10 months ago (2015-02-24 06:33:04 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 08:22:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190721

Powered by Google App Engine
This is Rietveld 408576698