Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: src/preparser.cc

Issue 939303002: Replace is_reference_error bool argument with ParseErrorType enum (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Marja comments addressed Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/preparser.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/preparser.cc
diff --git a/src/preparser.cc b/src/preparser.cc
index 154a9ae5278116fc3f96cf220962afa13feb518c..e7fff33d3bf7f6d47b96a9debbe5ac7a52c0957f 100644
--- a/src/preparser.cc
+++ b/src/preparser.cc
@@ -21,24 +21,16 @@ namespace v8 {
namespace internal {
void PreParserTraits::ReportMessageAt(Scanner::Location location,
- const char* message,
- const char* arg,
- bool is_reference_error) {
- ReportMessageAt(location.beg_pos,
- location.end_pos,
- message,
- arg,
- is_reference_error);
+ const char* message, const char* arg,
+ ParseErrorType error_type) {
+ ReportMessageAt(location.beg_pos, location.end_pos, message, arg, error_type);
}
-void PreParserTraits::ReportMessageAt(int start_pos,
- int end_pos,
- const char* message,
- const char* arg,
- bool is_reference_error) {
- pre_parser_->log_->LogMessage(start_pos, end_pos, message, arg,
- is_reference_error);
+void PreParserTraits::ReportMessageAt(int start_pos, int end_pos,
+ const char* message, const char* arg,
+ ParseErrorType error_type) {
+ pre_parser_->log_->LogMessage(start_pos, end_pos, message, arg, error_type);
}
« no previous file with comments | « src/preparser.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698