Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: src/parser.h

Issue 939303002: Replace is_reference_error bool argument with ParseErrorType enum (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Marja comments addressed Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/globals.h ('k') | src/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parser.h
diff --git a/src/parser.h b/src/parser.h
index 4b0e77f6067e318946e377426337873f8c5639ea..0db201dc14a2eec4f37d393bea623e4cb1a82afd 100644
--- a/src/parser.h
+++ b/src/parser.h
@@ -492,20 +492,16 @@ class ParserTraits {
const AstRawString* arg, int pos);
// Reporting errors.
- void ReportMessageAt(Scanner::Location source_location,
- const char* message,
+ void ReportMessageAt(Scanner::Location source_location, const char* message,
const char* arg = NULL,
- bool is_reference_error = false);
- void ReportMessage(const char* message,
- const char* arg = NULL,
- bool is_reference_error = false);
- void ReportMessage(const char* message,
- const AstRawString* arg,
- bool is_reference_error = false);
- void ReportMessageAt(Scanner::Location source_location,
- const char* message,
+ ParseErrorType error_type = kSyntaxError);
+ void ReportMessage(const char* message, const char* arg = NULL,
+ ParseErrorType error_type = kSyntaxError);
+ void ReportMessage(const char* message, const AstRawString* arg,
+ ParseErrorType error_type = kSyntaxError);
+ void ReportMessageAt(Scanner::Location source_location, const char* message,
const AstRawString* arg,
- bool is_reference_error = false);
+ ParseErrorType error_type = kSyntaxError);
// "null" return type creators.
static const AstRawString* EmptyIdentifier() {
@@ -853,7 +849,7 @@ class Parser : public ParserBase<ParserTraits> {
const char* pending_error_message_;
const AstRawString* pending_error_arg_;
const char* pending_error_char_arg_;
- bool pending_error_is_reference_error_;
+ ParseErrorType pending_error_type_;
// Other information which will be stored in Parser and moved to Isolate after
// parsing.
« no previous file with comments | « src/globals.h ('k') | src/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698