Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 939263002: [App banners] Add RAPPOR support (Closed)

Created:
5 years, 10 months ago by gone
Modified:
5 years, 10 months ago
Reviewers:
Ted C, Steven Holte
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[App banners] Add RAPPOR support * Adds support for tracking which domains trigger app banners. These metrics are split between native apps and web apps since developers are likely to prefer one over the other. * Changes rappor.xml to have information about the new metrics. BUG=458548 Committed: https://crrev.com/da52b2f3ea91e809f640373b7cad609725ea7877 Cr-Commit-Position: refs/heads/master@{#317158}

Patch Set 1 #

Patch Set 2 : Prettified #

Patch Set 3 : Swapped out for new call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -1 line) Patch
M chrome/browser/android/banners/app_banner_infobar_delegate.cc View 1 2 4 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/android/banners/app_banner_manager.cc View 1 2 4 chunks +13 lines, -1 line 0 comments Download
M tools/metrics/rappor/rappor.xml View 1 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
gone
tedchoc@ for general changes holte@ for the RAPPOR callsites
5 years, 10 months ago (2015-02-19 20:36:25 UTC) #2
Ted C
On 2015/02/19 20:36:25, dfalcantara wrote: > tedchoc@ for general changes > holte@ for the RAPPOR ...
5 years, 10 months ago (2015-02-19 21:12:20 UTC) #3
Steven Holte
On 2015/02/19 21:12:20, Ted C wrote: > On 2015/02/19 20:36:25, dfalcantara wrote: > > tedchoc@ ...
5 years, 10 months ago (2015-02-19 21:22:59 UTC) #4
gone
Ah, cool. Thanks! Might make sense to update this doc: http://www.chromium.org/developers/design-documents/rappor
5 years, 10 months ago (2015-02-19 21:30:45 UTC) #6
Steven Holte
On 2015/02/19 21:30:45, dfalcantara wrote: > Ah, cool. Thanks! Might make sense to update this ...
5 years, 10 months ago (2015-02-19 22:18:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939263002/40001
5 years, 10 months ago (2015-02-19 22:24:05 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-19 23:02:00 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 23:02:35 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/da52b2f3ea91e809f640373b7cad609725ea7877
Cr-Commit-Position: refs/heads/master@{#317158}

Powered by Google App Engine
This is Rietveld 408576698