Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 939233004: Fixing remote wallpaper change in multi profile cases (Closed)

Created:
5 years, 10 months ago by Mr4D (OOO till 08-26)
Modified:
5 years, 10 months ago
Reviewers:
Nikita (slow), bshe
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org, xdai1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing remote wallpaper change in multi profile cases The problem was that if the wallpaper of the non active user got changed on a different system, the remote system would replace the wallpaper of the active desktop with the change, no matter which user currently was active. JS is supplying the browser-context to the api call which can be used to get the applications owner - and that is used to identify the proper user. Creating a test case for this scenario is a lot of work (setting up multi profile, running the wallpaper manager for both users, triggering a change in the app of one user to force a change, waiting until the change has trickled through the system, ..). Since the work required for an automated test feels rather complex and time consuming for this setup and the change itself is fairly straight forward and simple, so I did not create a test. BUG=459599 TEST=visual Committed: https://crrev.com/cdc6fb42259bb6364cdf26100947dfccc36a0c4b Cr-Commit-Position: refs/heads/master@{#317322}

Patch Set 1 #

Patch Set 2 : Changed reference to one more active user. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 5 chunks +23 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Mr4D (OOO till 08-26)
Please have a look!
5 years, 10 months ago (2015-02-19 20:22:31 UTC) #2
Mr4D (OOO till 08-26)
Ooops. Never mind. I have found something more here. Please wait..
5 years, 10 months ago (2015-02-19 20:23:31 UTC) #3
Mr4D (OOO till 08-26)
Now it's correct. Have a look!
5 years, 10 months ago (2015-02-19 20:53:17 UTC) #4
bshe
lgtm FYI xdai@
5 years, 10 months ago (2015-02-20 14:47:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939233004/20001
5 years, 10 months ago (2015-02-20 15:03:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-20 15:28:37 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/cdc6fb42259bb6364cdf26100947dfccc36a0c4b Cr-Commit-Position: refs/heads/master@{#317322}
5 years, 10 months ago (2015-02-20 15:29:35 UTC) #9
Nikita (slow)
5 years, 10 months ago (2015-02-25 15:02:30 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698