Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 939183003: Revert of Disable delaying of Apps installation on Chrome OS for first time sign-in (Closed)

Created:
5 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Andrew T Wilson (Slow), Dmitry Polukhin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable delaying of Apps installation on Chrome OS for first time sign-in (patchset #1 id:1 of https://codereview.chromium.org/931663007/) Reason for revert: Seems to have broken PDFExtensionTest, blocking Blink rolls. See crbug.com/460328. Original issue's description: > Disable delaying of Apps installation on Chrome OS for first time sign-in > > This behavior is introduced by a772ed62ff0641df984feffe977b1545e94d53f1. > It makes ExternalPrefLoader not being ready when user sign in to Chromebook for > the first time and accidentally blocks all installation of external extensions > if Chrome Sync is turned off, including force installed extensions by policy. > > BUG=457539 > TEST=manual > > Committed: https://crrev.com/9a5194c07bd95febb99e61cdaaf9e42e602bd0be > Cr-Commit-Position: refs/heads/master@{#317074} TBR=nkostylev@chromium.org,asargent@chromium.org,kalman@chromium.org,binjin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457539 Committed: https://crrev.com/8476015c8a209afc3a75dcaf97e09f98d271d7cc Cr-Commit-Position: refs/heads/master@{#317214}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/extensions/external_provider_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
Created Revert of Disable delaying of Apps installation on Chrome OS for first time sign-in
5 years, 10 months ago (2015-02-20 01:42:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939183003/1
5 years, 10 months ago (2015-02-20 01:43:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 01:44:33 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 01:45:14 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8476015c8a209afc3a75dcaf97e09f98d271d7cc
Cr-Commit-Position: refs/heads/master@{#317214}

Powered by Google App Engine
This is Rietveld 408576698