Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 939153002: Rename the 'or' function in the chromevox next output language to 'if'. (Closed)

Created:
5 years, 10 months ago by Peter Lundblad
Modified:
5 years, 10 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, dtseng+watch_chromium.org, je_julie(Not used), nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename the 'or' function in the chromevox next output language to 'if'. The semantic of this function matches the usual semantic of if better than or, since or usually returns the first of its arguments that is true, while if evaluates a condition and returns a second or third argument depending of the truth value of its first ditto. R=dtseng@chromium.org BUG= Committed: https://crrev.com/6e4300d896a8d4103fdb43276521feaf0a6dcd28 Cr-Commit-Position: refs/heads/master@{#317059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Peter Lundblad
5 years, 10 months ago (2015-02-19 15:54:32 UTC) #1
David Tseng
lgtm
5 years, 10 months ago (2015-02-19 16:14:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939153002/1
5 years, 10 months ago (2015-02-19 16:15:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 16:37:14 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 16:37:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e4300d896a8d4103fdb43276521feaf0a6dcd28
Cr-Commit-Position: refs/heads/master@{#317059}

Powered by Google App Engine
This is Rietveld 408576698