Telemetry: Fix several small problems in the profile creator.

Telemetry: Fix several small problems in the profile creator.

- The profile creator was using integer indexing into the tab list, which
non-deterministically fails. The new code uses dictionary lookup.
- The profile creator was not robust against several types of exceptions that
occur more frequently with developer builds of Chrome.

BUG=442546
Committed: https://crrev.com/0b384f1f3709333a2a4baf9de5661e1dbda40fa1
Cr-Commit-Position: refs/heads/master@{#317624}

[erikchen, 2015-02-19 19:58:48]

erikchen@chromium.org changed reviewers:
+ nednguyen@google.com

[erikchen, 2015-02-19 19:58:49]

nednguyen: Please review.

[nednguyen, 2015-02-19 20:05:04]

https://codereview.chromium.org/939143004/diff/1/tools/perf/profile_creators/...
File tools/perf/profile_creators/fast_navigation_profile_extender.py (right):

https://codereview.chromium.org/939143004/diff/1/tools/perf/profile_creators/...
tools/perf/profile_creators/fast_navigation_profile_extender.py:133: live_tab =
self._browser.tabs.GetTabById(tab.id)
If you have to do this just to get the "live tab", I feel like we are doing
something wrong here with the tab_list API.

https://codereview.chromium.org/939143004/diff/1/tools/perf/profile_creators/...
File tools/perf/profile_creators/history_profile_extender.py (right):

https://codereview.chromium.org/939143004/diff/1/tools/perf/profile_creators/...
tools/perf/profile_creators/history_profile_extender.py:87: bytes_in_megabyte =
2**20
Can you do this change in a different patch?

[erikchen, 2015-02-19 21:55:12]

nednguyen: PTAL

https://codereview.chromium.org/939143004/diff/1/tools/perf/profile_creators/...
File tools/perf/profile_creators/fast_navigation_profile_extender.py (right):

https://codereview.chromium.org/939143004/diff/1/tools/perf/profile_creators/...
tools/perf/profile_creators/fast_navigation_profile_extender.py:133: live_tab =
self._browser.tabs.GetTabById(tab.id)
On 2015/02/19 20:05:04, nednguyen wrote:
> If you have to do this just to get the "live tab", I feel like we are doing
> something wrong here with the tab_list API.

I've added comments - this method is doing more than just getting "live tabs".
It's intentionally avoiding stalled tabs.

https://codereview.chromium.org/939143004/diff/1/tools/perf/profile_creators/...
File tools/perf/profile_creators/history_profile_extender.py (right):

https://codereview.chromium.org/939143004/diff/1/tools/perf/profile_creators/...
tools/perf/profile_creators/history_profile_extender.py:87: bytes_in_megabyte =
2**20
On 2015/02/19 20:05:04, nednguyen wrote:
> Can you do this change in a different patch?

Done.

[erikchen, 2015-02-20 23:35:16]

Patchset #5 (id:80001) has been deleted

[erikchen, 2015-02-20 23:35:34]

nednguyen: PTAL

[nednguyen, 2015-02-20 23:39:18]

lgtm

https://codereview.chromium.org/939143004/diff/100001/tools/perf/profile_crea...
File tools/perf/profile_creators/fast_navigation_profile_extender.py (right):

https://codereview.chromium.org/939143004/diff/100001/tools/perf/profile_crea...
tools/perf/profile_creators/fast_navigation_profile_extender.py:137: live_tabs =
[tab for tab in self._navigation_tabs if tab.IsAlive()]
I don't think we have the web_contents.IsAlive() API yet.

[erikchen, 2015-02-21 01:39:38]

https://codereview.chromium.org/939143004/diff/100001/tools/perf/profile_crea...
File tools/perf/profile_creators/fast_navigation_profile_extender.py (right):

https://codereview.chromium.org/939143004/diff/100001/tools/perf/profile_crea...
tools/perf/profile_creators/fast_navigation_profile_extender.py:137: live_tabs =
[tab for tab in self._navigation_tabs if tab.IsAlive()]
On 2015/02/20 23:39:17, nednguyen wrote:
> I don't think we have the web_contents.IsAlive() API yet.

It just landed in a separate CL.

[erikchen, 2015-02-21 01:39:40]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-02-21 01:40:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/939143004/100001

[commit-bot: I haz the power, 2015-02-21 02:56:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-21 02:56:31]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[erikchen, 2015-02-23 18:24:34]

New patchsets have been uploaded after l-g-t-m from nednguyen@google.com

[erikchen, 2015-02-23 18:24:53]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-02-23 18:25:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/939143004/120001

[commit-bot: I haz the power, 2015-02-23 19:41:05]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2015-02-23 19:41:59]

Patchset 6 (id:??) landed as
https://crrev.com/0b384f1f3709333a2a4baf9de5661e1dbda40fa1
Cr-Commit-Position: refs/heads/master@{#317624}