Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 93913002: Fix dart2js crash on unresolved super call. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/co19/co19-dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart
diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
index 598dde2810cd88ad7795f4bbed9397dca5a73614..3e04dc9fb3c24d8f3853847fbddfd11ebb96ef65 100644
--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart
+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
@@ -2660,6 +2660,14 @@ class ResolverVisitor extends MappingVisitor<Element> {
// dynamic invocation, because we statically know what the target is.
} else if (!selector.applies(target, compiler)) {
warnArgumentMismatch(node, target);
+ if (node.isSuperCall) {
+ // Similar to what we do when we can't find super via selector
+ // in [resolveSend] above, we still need to register the invocation,
+ // because we might call [:super.noSuchMethod:] which calls
+ // [JSInvocationMirror._invokeOn].
+ world.registerDynamicInvocation(selector);
+ compiler.backend.registerSuperNoSuchMethod(mapping);
+ }
}
if (target != null && target.isForeign(compiler)) {
« no previous file with comments | « no previous file | tests/co19/co19-dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698