src/core/SkGlyphCache.cpp - Issue 939123002: Make fID and MixedID calculations private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkGlyphCache.cpp

Issue 939123002: Make fID and MixedID calculations private (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Support android build Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkGlyphCache.cpp

diff --git a/src/core/SkGlyphCache.cpp b/src/core/SkGlyphCache.cpp

index 57c54bfc1ec3f7f35d3c499ba14c26abe99bcdcf..f0fd859385e02d1c3dfb3be213b4421af6a4d5d5 100755

--- a/src/core/SkGlyphCache.cpp

+++ b/src/core/SkGlyphCache.cpp

@@ -314,7 +314,7 @@ SkGlyph* SkGlyphCache::lookupMetrics(uint32_t id, MetricsType mtype) {

glyph = (SkGlyph*)fGlyphAlloc.alloc(sizeof(SkGlyph),

SkChunkAlloc::kThrow_AllocFailType);

- glyph->init(id);

+ glyph->initCommon(id);

*fGlyphArray.insert(hi) = glyph;

if (kJustAdvance_MetricsType == mtype) {