Issue 939113002: Rename onGetPixelsEnum back to onGetPixels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 939113002: Rename onGetPixelsEnum back to onGetPixels. (Closed)

Created:
5 years, 10 months ago by scroggo

Modified:
5 years, 10 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Rename onGetPixelsEnum back to onGetPixels. Replace the old signature of onGetPixels (return bool) to return an enum (Result). Remove onGetPixelsEnum. Add a define for onGetPixelsEnum to onGetPixels. This is for staging in Chromium, where some implementations override onGetPixelsEnum. Add the define in skia_for_chromium_defines. Remove SK_SUPPORT_LEGACY_IMAGE_GENERATOR_RETURN, which is no longer needed by Chromium. BUG=skia:3257 Committed: https://skia.googlesource.com/skia/+/87fa631969e0bdbee3c0845aa2b9bf35b9b82eb0

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -31 lines)			Patch
M	gyp/skia_for_chromium_defines.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkImageGenerator.h	View	2 chunks	+8 lines, -10 lines	0 comments	Download
M	src/core/SkImageGenerator.cpp	View	2 chunks	+2 lines, -14 lines	0 comments	Download
M	src/images/SkDecodingImageGenerator.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/ports/SkImageGenerator_skia.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/CachedDecodingPixelRefTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939113002/1

5 years, 10 months ago (2015-02-19 20:52:36 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-20 02:45:02 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/87fa631969e0bdbee3c0845aa2b9bf35b9b82eb0

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages