Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 939073003: Disable ICF for sanitizer builds to preserve the debug info. (Closed)

Created:
5 years, 10 months ago by Alexander Potapenko
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ICF for sanitizer builds to preserve the debug info. BUG=460034 Committed: https://crrev.com/1c36fa1e577ed5c7d6e70f099ad08656e1ff825a Cr-Commit-Position: refs/heads/master@{#317288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M build/common.gypi View 5 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Alexander Potapenko
Please take a look.
5 years, 10 months ago (2015-02-19 14:37:23 UTC) #2
Nico
lgtm
5 years, 10 months ago (2015-02-19 15:27:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939073003/1
5 years, 10 months ago (2015-02-20 08:46:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 11:13:18 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 11:14:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c36fa1e577ed5c7d6e70f099ad08656e1ff825a
Cr-Commit-Position: refs/heads/master@{#317288}

Powered by Google App Engine
This is Rietveld 408576698