Chromium Code Reviews| Index: cc/resources/resource_provider_unittest.cc |
| diff --git a/cc/resources/resource_provider_unittest.cc b/cc/resources/resource_provider_unittest.cc |
| index 2bba801b5359e7f502b1c393b100291687945321..8e59434d56076d3fce867e17b17d42a88b87c1e6 100644 |
| --- a/cc/resources/resource_provider_unittest.cc |
| +++ b/cc/resources/resource_provider_unittest.cc |
| @@ -522,8 +522,7 @@ void CheckCreateResource(ResourceProvider::ResourceType expected_default_type, |
| EXPECT_EQ(0u, context->NumTextures()); |
| uint8_t data[4] = { 1, 2, 3, 4 }; |
| - gfx::Rect rect(size); |
| - resource_provider->SetPixels(id, data, rect, rect, gfx::Vector2d()); |
| + resource_provider->CopyToResource(id, data, size); |
| if (expected_default_type == ResourceProvider::GLTexture) |
| EXPECT_EQ(1u, context->NumTextures()); |
| @@ -608,6 +607,38 @@ TEST_P(ResourceProviderTest, Upload) { |
| resource_provider_->DeleteResource(id); |
| } |
| +TEST_P(ResourceProviderTest, SimpleUpload) { |
|
enne (OOO)
2015/02/19 01:01:27
Would it make sense to test bitmap and ETC1 resour
danakj
2015/02/19 01:03:56
Hm!
Bitmap should be covered by TEST_P-ness. But
|
| + gfx::Size size(2, 2); |
| + ResourceFormat format = RGBA_8888; |
| + size_t pixel_size = TextureSizeBytes(size, format); |
| + ASSERT_EQ(16U, pixel_size); |
| + |
| + ResourceProvider::ResourceId id = resource_provider_->CreateResource( |
| + size, GL_CLAMP_TO_EDGE, ResourceProvider::TextureHintImmutable, format); |
| + |
| + uint8_t image[16] = {0}; |
| + resource_provider_->CopyToResource(id, image, size); |
| + { |
| + uint8_t result[16] = {0}; |
| + uint8_t expected[16] = {0}; |
| + GetResourcePixels(resource_provider_.get(), context(), id, size, format, |
| + result); |
| + EXPECT_EQ(0, memcmp(expected, result, pixel_size)); |
| + } |
| + |
| + for (uint8_t i = 0; i < pixel_size; ++i) |
| + image[i] = i; |
| + resource_provider_->CopyToResource(id, image, size); |
| + { |
| + uint8_t result[16] = {0}; |
| + uint8_t expected[16] = { |
| + 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15}; |
| + GetResourcePixels(resource_provider_.get(), context(), id, size, format, |
| + result); |
| + EXPECT_EQ(0, memcmp(expected, result, pixel_size)); |
| + } |
| +} |
| + |
| TEST_P(ResourceProviderTest, TransferGLResources) { |
| if (GetParam() != ResourceProvider::GLTexture) |
| return; |