Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 938893002: cc: Stop using TextureUploader for UIResources, HUD, and tests. (Closed)

Created:
5 years, 10 months ago by danakj
Modified:
5 years, 10 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, ericrk, piman, vmpstr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Stop using TextureUploader for UIResources, HUD, and tests. This adds a new simpler method to ResourceProvider called CopyToResource and uses that instead. This removes TextureUploader from the path of most impl-side painting code. R=enne BUG=454575 Committed: https://crrev.com/8d86c9e54e34d7c4b75b6c94689ef28b1fe65dfb Cr-Commit-Position: refs/heads/master@{#316978}

Patch Set 1 #

Patch Set 2 : uiresource: . #

Total comments: 2

Patch Set 3 : uiresource: etc1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -125 lines) Patch
M cc/layers/heads_up_display_layer_impl.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 5 chunks +18 lines, -38 lines 0 comments Download
M cc/output/software_renderer_unittest.cc View 2 chunks +7 lines, -16 lines 0 comments Download
M cc/resources/resource_provider.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 1 2 16 chunks +50 lines, -31 lines 0 comments Download
M cc/resources/texture_uploader.cc View 1 2 2 chunks +1 line, -24 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
danakj
After this, the remaining hold outs are the VideoResourceUpdater and async uploads.
5 years, 10 months ago (2015-02-19 00:53:44 UTC) #1
enne (OOO)
https://codereview.chromium.org/938893002/diff/20001/cc/resources/resource_provider_unittest.cc File cc/resources/resource_provider_unittest.cc (right): https://codereview.chromium.org/938893002/diff/20001/cc/resources/resource_provider_unittest.cc#newcode610 cc/resources/resource_provider_unittest.cc:610: TEST_P(ResourceProviderTest, SimpleUpload) { Would it make sense to test ...
5 years, 10 months ago (2015-02-19 01:01:27 UTC) #2
danakj
https://codereview.chromium.org/938893002/diff/20001/cc/resources/resource_provider_unittest.cc File cc/resources/resource_provider_unittest.cc (right): https://codereview.chromium.org/938893002/diff/20001/cc/resources/resource_provider_unittest.cc#newcode610 cc/resources/resource_provider_unittest.cc:610: TEST_P(ResourceProviderTest, SimpleUpload) { On 2015/02/19 01:01:27, enne wrote: > ...
5 years, 10 months ago (2015-02-19 01:03:56 UTC) #3
danakj
On 2015/02/19 01:03:56, danakj wrote: > https://codereview.chromium.org/938893002/diff/20001/cc/resources/resource_provider_unittest.cc > File cc/resources/resource_provider_unittest.cc (right): > > https://codereview.chromium.org/938893002/diff/20001/cc/resources/resource_provider_unittest.cc#newcode610 > ...
5 years, 10 months ago (2015-02-19 01:38:41 UTC) #4
danakj
PTAL
5 years, 10 months ago (2015-02-19 01:39:34 UTC) #5
enne (OOO)
lgtm
5 years, 10 months ago (2015-02-19 01:40:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938893002/40001
5 years, 10 months ago (2015-02-19 01:41:42 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-19 02:41:17 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 02:41:44 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8d86c9e54e34d7c4b75b6c94689ef28b1fe65dfb
Cr-Commit-Position: refs/heads/master@{#316978}

Powered by Google App Engine
This is Rietveld 408576698