Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 938883002: [Android] Rework instrumentation test skipping and result generation. (Closed)

Created:
5 years, 10 months ago by jbudorick
Modified:
5 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Rework instrumentation test skipping and result generation. BUG=428729, 444049 Committed: https://crrev.com/1db82a2afb7a760644ab08fcd79afc3c49b76b2b Cr-Commit-Position: refs/heads/master@{#317456}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Messages

Total messages: 13 (5 generated)
jbudorick
5 years, 10 months ago (2015-02-19 01:35:40 UTC) #2
klundberg1
LGTM https://codereview.chromium.org/938883002/diff/20001/build/android/pylib/instrumentation/instrumentation_test_instance.py File build/android/pylib/instrumentation/instrumentation_test_instance.py (right): https://codereview.chromium.org/938883002/diff/20001/build/android/pylib/instrumentation/instrumentation_test_instance.py#newcode66 build/android/pylib/instrumentation/instrumentation_test_instance.py:66: result_code: Any reason why you don't have doc ...
5 years, 10 months ago (2015-02-19 15:19:36 UTC) #4
jbudorick
https://codereview.chromium.org/938883002/diff/20001/build/android/pylib/instrumentation/instrumentation_test_instance.py File build/android/pylib/instrumentation/instrumentation_test_instance.py (right): https://codereview.chromium.org/938883002/diff/20001/build/android/pylib/instrumentation/instrumentation_test_instance.py#newcode66 build/android/pylib/instrumentation/instrumentation_test_instance.py:66: result_code: On 2015/02/19 15:19:35, klundberg1 wrote: > Any reason ...
5 years, 10 months ago (2015-02-19 19:39:51 UTC) #6
nyquist
base/test/android lgtm https://codereview.chromium.org/938883002/diff/40001/base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java File base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java (right): https://codereview.chromium.org/938883002/diff/40001/base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java#newcode36 base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java:36: * @return true if the test case ...
5 years, 10 months ago (2015-02-20 19:59:54 UTC) #7
jbudorick
https://codereview.chromium.org/938883002/diff/40001/base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java File base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java (right): https://codereview.chromium.org/938883002/diff/40001/base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java#newcode36 base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java:36: * @return true if the test case should be ...
5 years, 10 months ago (2015-02-20 22:04:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938883002/60001
5 years, 10 months ago (2015-02-20 22:05:43 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-21 00:47:53 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-21 00:49:15 UTC) #13
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/1db82a2afb7a760644ab08fcd79afc3c49b76b2b
Cr-Commit-Position: refs/heads/master@{#317456}

Powered by Google App Engine
This is Rietveld 408576698