Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: sync/protocol/proto_enum_conversions.cc

Issue 93883004: Sync the launch type pref for apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unfix nit because it prevents testing of how invalid values are handled Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/protocol/proto_enum_conversions.h ('k') | sync/protocol/proto_value_conversions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/protocol/proto_enum_conversions.cc
diff --git a/sync/protocol/proto_enum_conversions.cc b/sync/protocol/proto_enum_conversions.cc
index af958222414b6369e28dd2900b121d42080423f4..c624efe500dae850422bbd96b1e28dd35c726e1a 100644
--- a/sync/protocol/proto_enum_conversions.cc
+++ b/sync/protocol/proto_enum_conversions.cc
@@ -170,6 +170,18 @@ const char* GetActionString(sync_pb::SyncEnums::Action action) {
}
+const char* GetLaunchTypeString(sync_pb::AppSpecifics::LaunchType launch_type) {
+ ASSERT_ENUM_BOUNDS(sync_pb::AppSpecifics, LaunchType, PINNED, WINDOW);
+ switch (launch_type) {
+ ENUM_CASE(sync_pb::AppSpecifics, PINNED);
+ ENUM_CASE(sync_pb::AppSpecifics, REGULAR);
+ ENUM_CASE(sync_pb::AppSpecifics, FULLSCREEN);
+ ENUM_CASE(sync_pb::AppSpecifics, WINDOW);
+ }
+ NOTREACHED();
+ return "";
+}
+
const char* GetDeviceTypeString(
sync_pb::SyncEnums::DeviceType device_type) {
ASSERT_ENUM_BOUNDS(sync_pb::SyncEnums, DeviceType, TYPE_WIN, TYPE_TABLET);
« no previous file with comments | « sync/protocol/proto_enum_conversions.h ('k') | sync/protocol/proto_value_conversions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698