chrome/browser/ui/webui/ntp/app_launcher_handler.cc - Issue 93883004: Sync the launch type pref for apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/app_launcher_handler.cc

Issue 93883004: Sync the launch type pref for apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unfix nit because it prevents testing of how invalid values are handled Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/ntp/app_launcher_handler.cc

diff --git a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc

index 3330da6abba0c5dc089003afa470fa1641c27965..cada3231b3c5faf1be3471f0ead6a114f6b130b4 100644

--- a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc

+++ b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc

@@ -568,10 +568,9 @@ void AppLauncherHandler::HandleSetLaunchType(const base::ListValue* args) {

base::AutoReset<bool> auto_reset(&ignore_changes_, true);

extensions::SetLaunchType(

- extension_service_->extension_prefs(),

+ extension_service_,

extension_id,

- static_cast<extensions::LaunchType>(

- static_cast<int>(launch_type)));

+ static_cast<extensions::LaunchType>(static_cast<int>(launch_type)));

}

void AppLauncherHandler::HandleUninstallApp(const base::ListValue* args) {