Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Unified Diff: chrome/browser/extensions/extension_sync_service.cc

Issue 93883004: Sync the launch type pref for apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: better launch type validity checks Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_sync_service.cc
diff --git a/chrome/browser/extensions/extension_sync_service.cc b/chrome/browser/extensions/extension_sync_service.cc
index 9aa0dd3240073cc21ae45bd8ae495184a9a0411f..421d7e473d7384e731c281001ee18ac79fd01e10 100644
--- a/chrome/browser/extensions/extension_sync_service.cc
+++ b/chrome/browser/extensions/extension_sync_service.cc
@@ -16,6 +16,7 @@
#include "chrome/browser/extensions/extension_sync_data.h"
#include "chrome/browser/extensions/extension_sync_service_factory.h"
#include "chrome/browser/extensions/extension_util.h"
+#include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/sync/glue/sync_start_util.h"
#include "chrome/browser/sync/sync_prefs.h"
@@ -239,7 +240,11 @@ extensions::AppSyncData ExtensionSyncService::GetAppSyncData(
extension_service_->IsExtensionEnabled(extension.id()),
extension_util::IsIncognitoEnabled(extension.id(), extension_service_),
extension_prefs_->app_sorting()->GetAppLaunchOrdinal(extension.id()),
- extension_prefs_->app_sorting()->GetPageOrdinal(extension.id()));
+ extension_prefs_->app_sorting()->GetPageOrdinal(extension.id()),
+ extensions::HasPreferredLaunchType(extension_prefs_, &extension)
+ ? extensions::GetLaunchType(extension_prefs_, &extension)
+ : extensions::LAUNCH_TYPE_INVALID);
+
}
std::vector<extensions::ExtensionSyncData>
@@ -307,6 +312,12 @@ bool ExtensionSyncService::ProcessAppSyncData(
app_sync_data.page_ordinal());
}
+ if (app_sync_data.launch_type() >= extensions::LAUNCH_TYPE_FIRST &&
+ app_sync_data.launch_type() < extensions::NUM_LAUNCH_TYPES) {
+ extensions::SetLaunchType(extension_service_, id,
+ static_cast<extensions::LaunchType>(app_sync_data.launch_type()));
+ }
+
if (!ProcessExtensionSyncDataHelper(app_sync_data.extension_sync_data(),
syncer::APPS)) {
app_sync_bundle_.AddPendingApp(id, app_sync_data);

Powered by Google App Engine
This is Rietveld 408576698