Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chrome/common/extensions/extension_constants.h

Issue 93883004: Sync the launch type pref for apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unfix nit because it prevents testing of how invalid values are handled Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/ntp/app_launcher_handler.cc ('k') | sync/protocol/app_specifics.proto » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_
6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_ 6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 304 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 extern const int kScriptBadgeIconSizes[]; 315 extern const int kScriptBadgeIconSizes[];
316 extern const size_t kNumScriptBadgeIconSizes; 316 extern const size_t kNumScriptBadgeIconSizes;
317 } // namespace extension_misc 317 } // namespace extension_misc
318 318
319 namespace extensions { 319 namespace extensions {
320 // This enum is used for the launch type the user wants to use for an 320 // This enum is used for the launch type the user wants to use for an
321 // application. 321 // application.
322 // Do not remove items or re-order this enum as it is used in preferences 322 // Do not remove items or re-order this enum as it is used in preferences
323 // and histograms. 323 // and histograms.
324 enum LaunchType { 324 enum LaunchType {
325 LAUNCH_TYPE_PINNED, 325 LAUNCH_TYPE_INVALID = -1,
326 LAUNCH_TYPE_REGULAR, 326 LAUNCH_TYPE_FIRST = 0,
327 LAUNCH_TYPE_FULLSCREEN, 327 LAUNCH_TYPE_PINNED = LAUNCH_TYPE_FIRST,
328 LAUNCH_TYPE_WINDOW, 328 LAUNCH_TYPE_REGULAR = 1,
329 LAUNCH_TYPE_FULLSCREEN = 2,
330 LAUNCH_TYPE_WINDOW = 3,
331 NUM_LAUNCH_TYPES,
329 332
330 // Launch an app in the in the way a click on the NTP would, 333 // Launch an app in the in the way a click on the NTP would,
331 // if no user pref were set. Update this constant to change 334 // if no user pref were set. Update this constant to change
332 // the default for the NTP and chrome.management.launchApp(). 335 // the default for the NTP and chrome.management.launchApp().
333 LAUNCH_TYPE_DEFAULT = LAUNCH_TYPE_REGULAR 336 LAUNCH_TYPE_DEFAULT = LAUNCH_TYPE_REGULAR
334 }; 337 };
335 338
336 // Don't remove items or change the order of this enum. It's used in 339 // Don't remove items or change the order of this enum. It's used in
337 // histograms and preferences. 340 // histograms and preferences.
338 enum LaunchContainer { 341 enum LaunchContainer {
339 LAUNCH_CONTAINER_WINDOW, 342 LAUNCH_CONTAINER_WINDOW,
340 LAUNCH_CONTAINER_PANEL, 343 LAUNCH_CONTAINER_PANEL,
341 LAUNCH_CONTAINER_TAB, 344 LAUNCH_CONTAINER_TAB,
342 // For platform apps, which don't actually have a container (they just get a 345 // For platform apps, which don't actually have a container (they just get a
343 // "onLaunched" event). 346 // "onLaunched" event).
344 LAUNCH_CONTAINER_NONE 347 LAUNCH_CONTAINER_NONE
345 }; 348 };
346 } // namespace extensions 349 } // namespace extensions
347 350
348 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_ 351 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/ntp/app_launcher_handler.cc ('k') | sync/protocol/app_specifics.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698