Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: chrome/common/extensions/extension_constants.h

Issue 93883004: Sync the launch type pref for apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: better launch type validity checks Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_
6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_ 6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 extern const int kScriptBadgeIconSizes[]; 312 extern const int kScriptBadgeIconSizes[];
313 extern const size_t kNumScriptBadgeIconSizes; 313 extern const size_t kNumScriptBadgeIconSizes;
314 } // namespace extension_misc 314 } // namespace extension_misc
315 315
316 namespace extensions { 316 namespace extensions {
317 // This enum is used for the launch type the user wants to use for an 317 // This enum is used for the launch type the user wants to use for an
318 // application. 318 // application.
319 // Do not remove items or re-order this enum as it is used in preferences 319 // Do not remove items or re-order this enum as it is used in preferences
320 // and histograms. 320 // and histograms.
321 enum LaunchType { 321 enum LaunchType {
322 LAUNCH_TYPE_PINNED, 322 LAUNCH_TYPE_INVALID = -1,
323 LAUNCH_TYPE_REGULAR, 323 LAUNCH_TYPE_FIRST = 0,
324 LAUNCH_TYPE_FULLSCREEN, 324 LAUNCH_TYPE_PINNED = LAUNCH_TYPE_FIRST,
325 LAUNCH_TYPE_WINDOW, 325 LAUNCH_TYPE_REGULAR = 1,
326 LAUNCH_TYPE_FULLSCREEN = 2,
327 LAUNCH_TYPE_WINDOW = 3,
328 NUM_LAUNCH_TYPES,
326 329
327 // Launch an app in the in the way a click on the NTP would, 330 // Launch an app in the in the way a click on the NTP would,
328 // if no user pref were set. Update this constant to change 331 // if no user pref were set. Update this constant to change
329 // the default for the NTP and chrome.management.launchApp(). 332 // the default for the NTP and chrome.management.launchApp().
330 LAUNCH_TYPE_DEFAULT = LAUNCH_TYPE_REGULAR 333 LAUNCH_TYPE_DEFAULT = LAUNCH_TYPE_REGULAR
331 }; 334 };
332 335
333 // Don't remove items or change the order of this enum. It's used in 336 // Don't remove items or change the order of this enum. It's used in
334 // histograms and preferences. 337 // histograms and preferences.
335 enum LaunchContainer { 338 enum LaunchContainer {
336 LAUNCH_CONTAINER_WINDOW, 339 LAUNCH_CONTAINER_WINDOW,
337 LAUNCH_CONTAINER_PANEL, 340 LAUNCH_CONTAINER_PANEL,
338 LAUNCH_CONTAINER_TAB, 341 LAUNCH_CONTAINER_TAB,
339 // For platform apps, which don't actually have a container (they just get a 342 // For platform apps, which don't actually have a container (they just get a
340 // "onLaunched" event). 343 // "onLaunched" event).
341 LAUNCH_CONTAINER_NONE 344 LAUNCH_CONTAINER_NONE
342 }; 345 };
343 } // namespace extensions 346 } // namespace extensions
344 347
345 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_ 348 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_CONSTANTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698