Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 938793005: Android: Value of input[type=datetime-local] should not spill out from the content box. (Closed)

Created:
5 years, 10 months ago by tkent
Modified:
5 years, 10 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Android: Value of input[type=datetime-local] should not spill out from the content box. - input[type=datetime-local] should have larger default width. - If the content box has no enough space for the value, the value should be cut off. BUG=414412 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190727

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M Source/core/css/themeChromiumAndroid.css View 1 chunk +5 lines, -0 lines 3 comments Download

Messages

Total messages: 8 (2 generated)
tkent
Keishi, please review this.
5 years, 10 months ago (2015-02-24 06:35:15 UTC) #2
keishi
https://codereview.chromium.org/938793005/diff/1/Source/core/css/themeChromiumAndroid.css File Source/core/css/themeChromiumAndroid.css (right): https://codereview.chromium.org/938793005/diff/1/Source/core/css/themeChromiumAndroid.css#newcode72 Source/core/css/themeChromiumAndroid.css:72: input[type="datetime-local" i] { What does the " i" do?
5 years, 10 months ago (2015-02-24 08:09:58 UTC) #3
tkent
https://codereview.chromium.org/938793005/diff/1/Source/core/css/themeChromiumAndroid.css File Source/core/css/themeChromiumAndroid.css (right): https://codereview.chromium.org/938793005/diff/1/Source/core/css/themeChromiumAndroid.css#newcode72 Source/core/css/themeChromiumAndroid.css:72: input[type="datetime-local" i] { On 2015/02/24 08:09:58, keishi wrote: > ...
5 years, 10 months ago (2015-02-24 08:22:05 UTC) #4
keishi
https://codereview.chromium.org/938793005/diff/1/Source/core/css/themeChromiumAndroid.css File Source/core/css/themeChromiumAndroid.css (right): https://codereview.chromium.org/938793005/diff/1/Source/core/css/themeChromiumAndroid.css#newcode72 Source/core/css/themeChromiumAndroid.css:72: input[type="datetime-local" i] { On 2015/02/24 08:22:05, tkent wrote: > ...
5 years, 10 months ago (2015-02-24 08:27:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938793005/1
5 years, 10 months ago (2015-02-24 08:39:06 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 08:43:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190727

Powered by Google App Engine
This is Rietveld 408576698