Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 938763004: Do not build breakpad tool on target when cross-compiling for iOS (Closed)

Created:
5 years, 10 months ago by sdefresne
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not build breakpad tool on target when cross-compiling for iOS The "microdump_stackwalk", "minidump_stackwalk", and "minidump_dump" tools are not expected to be run on the device, so only build them for "host" toolset not "target" when targetting iOS. When building for other targets build the tools both for "host" and "target" to fix compilation of ChromeOS build in `cros chrome-sdk` shells. BUG=459035 TBR=mark Committed: https://chromium.googlesource.com/chromium/src/+/8196d17c34a51b5b00df2e43bcd8f3ad8a74b5d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M breakpad/breakpad.gyp View 5 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
sdefresne
Mark: can you take a look? I hear this is blocking cros guys.
5 years, 10 months ago (2015-02-18 19:55:53 UTC) #2
sdefresne
TBR-ing since this is resolving a tree closure for ChromeOS.
5 years, 10 months ago (2015-02-18 20:03:48 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8196d17c34a51b5b00df2e43bcd8f3ad8a74b5d5 Cr-Commit-Position: refs/heads/master@{#316879}
5 years, 10 months ago (2015-02-18 20:06:49 UTC) #4
sdefresne
Committed patchset #1 (id:1) manually as 8196d17c34a51b5b00df2e43bcd8f3ad8a74b5d5 (presubmit successful).
5 years, 10 months ago (2015-02-18 20:07:00 UTC) #5
Steve McKay
LGTM. Tested locally and it fixed my Chrome OS cros shell build.
5 years, 10 months ago (2015-02-18 20:11:22 UTC) #6
Mark Mentovai
5 years, 10 months ago (2015-02-18 21:05:06 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698