Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp - Issue 938733003: IDL: Fix exception handling when converting V8 value to union/dictionary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

Issue 938733003: IDL: Fix exception handling when converting V8 value to union/dictionary (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestDictionary.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

diff --git a/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp b/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

index 189661495ebe5faf5fd5aecea5c3f49cbf5bd844..f6f48b4b4c76408d52895a9b32e593c97ae89300 100644

--- a/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

+++ b/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

@@ -35,7 +35,7 @@ void V8TestDictionaryDerivedImplementedAs::toImpl(v8::Isolate* isolate, v8::Loca

if (derivedStringMemberValue.IsEmpty() || derivedStringMemberValue->IsUndefined()) {

// Do nothing.

} else {

- TOSTRING_VOID(V8StringResource<>, derivedStringMember, derivedStringMemberValue);

+ TOSTRING_VOID_EXCEPTIONSTATE(V8StringResource<>, derivedStringMember, derivedStringMemberValue, exceptionState);

impl.setDerivedStringMember(derivedStringMember);

}

@@ -47,7 +47,7 @@ void V8TestDictionaryDerivedImplementedAs::toImpl(v8::Isolate* isolate, v8::Loca

if (derivedStringMemberWithDefaultValue.IsEmpty() || derivedStringMemberWithDefaultValue->IsUndefined()) {

// Do nothing.

} else {

- TOSTRING_VOID(V8StringResource<>, derivedStringMemberWithDefault, derivedStringMemberWithDefaultValue);

+ TOSTRING_VOID_EXCEPTIONSTATE(V8StringResource<>, derivedStringMemberWithDefault, derivedStringMemberWithDefaultValue, exceptionState);

impl.setDerivedStringMemberWithDefault(derivedStringMemberWithDefault);

}