Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: Source/bindings/tests/results/core/UnionTypesCore.cpp

Issue 938733003: IDL: Fix exception handling when converting V8 value to union/dictionary (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_union.py ('k') | Source/bindings/tests/results/core/V8TestDictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/core/UnionTypesCore.cpp
diff --git a/Source/bindings/tests/results/core/UnionTypesCore.cpp b/Source/bindings/tests/results/core/UnionTypesCore.cpp
index 9ad9b6f00a0fc830a9710a2a250a81c723fb2ea6..bae30c9781fb9d02c86ca3dba472891f2da68658 100644
--- a/Source/bindings/tests/results/core/UnionTypesCore.cpp
+++ b/Source/bindings/tests/results/core/UnionTypesCore.cpp
@@ -114,7 +114,7 @@ void V8ArrayBufferOrArrayBufferViewOrDictionary::toImpl(v8::Isolate* isolate, v8
}
if (isUndefinedOrNull(v8Value) || v8Value->IsObject()) {
- TONATIVE_VOID_EXCEPTIONSTATE(Dictionary, cppValue, Dictionary(v8Value, isolate, exceptionState), exceptionState);
+ TONATIVE_VOID_EXCEPTIONSTATE_NOTHROW(Dictionary, cppValue, Dictionary(v8Value, isolate, exceptionState), exceptionState);
impl.setDictionary(cppValue);
return;
}
@@ -222,7 +222,7 @@ void V8BooleanOrStringOrUnrestrictedDouble::toImpl(v8::Isolate* isolate, v8::Loc
}
if (v8Value->IsNumber()) {
- TONATIVE_VOID_EXCEPTIONSTATE(double, cppValue, toDouble(v8Value, exceptionState), exceptionState);
+ TONATIVE_VOID_EXCEPTIONSTATE_NOTHROW(double, cppValue, toDouble(v8Value, exceptionState), exceptionState);
impl.setUnrestrictedDouble(cppValue);
return;
}
@@ -310,7 +310,7 @@ void V8DoubleOrString::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value
return;
if (v8Value->IsNumber()) {
- TONATIVE_VOID_EXCEPTIONSTATE(double, cppValue, toRestrictedDouble(v8Value, exceptionState), exceptionState);
+ TONATIVE_VOID_EXCEPTIONSTATE_NOTHROW(double, cppValue, toRestrictedDouble(v8Value, exceptionState), exceptionState);
impl.setDouble(cppValue);
return;
}
@@ -603,7 +603,7 @@ void V8StringOrDouble::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value
return;
if (v8Value->IsNumber()) {
- TONATIVE_VOID_EXCEPTIONSTATE(double, cppValue, toRestrictedDouble(v8Value, exceptionState), exceptionState);
+ TONATIVE_VOID_EXCEPTIONSTATE_NOTHROW(double, cppValue, toRestrictedDouble(v8Value, exceptionState), exceptionState);
impl.setDouble(cppValue);
return;
}
@@ -689,7 +689,7 @@ void V8StringOrStringSequence::toImpl(v8::Isolate* isolate, v8::Local<v8::Value>
return;
if (v8Value->IsArray()) {
- TONATIVE_VOID_EXCEPTIONSTATE(Vector<String>, cppValue, toImplArray<String>(v8Value, 0, isolate, exceptionState), exceptionState);
+ TONATIVE_VOID_EXCEPTIONSTATE_NOTHROW(Vector<String>, cppValue, toImplArray<String>(v8Value, 0, isolate, exceptionState), exceptionState);
impl.setStringSequence(cppValue);
return;
}
@@ -780,7 +780,7 @@ void V8TestEnumOrDouble::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Val
return;
if (v8Value->IsNumber()) {
- TONATIVE_VOID_EXCEPTIONSTATE(double, cppValue, toRestrictedDouble(v8Value, exceptionState), exceptionState);
+ TONATIVE_VOID_EXCEPTIONSTATE_NOTHROW(double, cppValue, toRestrictedDouble(v8Value, exceptionState), exceptionState);
impl.setDouble(cppValue);
return;
}
@@ -1055,13 +1055,13 @@ void V8TestInterfaceOrLong::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8
}
if (v8Value->IsNumber()) {
- TONATIVE_VOID_EXCEPTIONSTATE(int, cppValue, toInt32(v8Value, exceptionState), exceptionState);
+ TONATIVE_VOID_EXCEPTIONSTATE_NOTHROW(int, cppValue, toInt32(v8Value, exceptionState), exceptionState);
impl.setLong(cppValue);
return;
}
{
- TONATIVE_VOID_EXCEPTIONSTATE(int, cppValue, toInt32(v8Value, exceptionState), exceptionState);
+ TONATIVE_VOID_EXCEPTIONSTATE_NOTHROW(int, cppValue, toInt32(v8Value, exceptionState), exceptionState);
impl.setLong(cppValue);
return;
}
@@ -1241,7 +1241,7 @@ void V8TestInterfaceWillBeGarbageCollectedOrTestDictionary::toImpl(v8::Isolate*
if (isUndefinedOrNull(v8Value) || v8Value->IsObject()) {
TestDictionary cppValue;
- TONATIVE_VOID_EXCEPTIONSTATE_ARGINTERNAL(V8TestDictionary::toImpl(isolate, v8Value, cppValue, exceptionState), exceptionState);
+ TONATIVE_VOID_EXCEPTIONSTATE_ARGINTERNAL_NOTHROW(V8TestDictionary::toImpl(isolate, v8Value, cppValue, exceptionState), exceptionState);
impl.setTestDictionary(cppValue);
return;
}
@@ -1322,7 +1322,7 @@ void V8UnrestrictedDoubleOrString::toImpl(v8::Isolate* isolate, v8::Local<v8::Va
return;
if (v8Value->IsNumber()) {
- TONATIVE_VOID_EXCEPTIONSTATE(double, cppValue, toDouble(v8Value, exceptionState), exceptionState);
+ TONATIVE_VOID_EXCEPTIONSTATE_NOTHROW(double, cppValue, toDouble(v8Value, exceptionState), exceptionState);
impl.setUnrestrictedDouble(cppValue);
return;
}
« no previous file with comments | « Source/bindings/scripts/v8_union.py ('k') | Source/bindings/tests/results/core/V8TestDictionary.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698