IndexedDBFactory now ForceCloses databases.

content/browser/indexed_db/indexed_db_factory.cc

Index: content/browser/indexed_db/indexed_db_factory.cc
diff --git a/content/browser/indexed_db/indexed_db_factory.cc b/content/browser/indexed_db/indexed_db_factory.cc
index fb46b8f2c13db55737bc6e617d90f52415f67b13..723a162ec3a17ebd742b937996389eaade283671 100644
--- a/content/browser/indexed_db/indexed_db_factory.cc
+++ b/content/browser/indexed_db/indexed_db_factory.cc
@@ -90,6 +90,12 @@ bool IndexedDBFactory::HasLastBackingStoreReference(const GURL& origin_url)
 }
 
 void IndexedDBFactory::ForceClose(const GURL& origin_url) {
+  std::vector<IndexedDBDatabase*> dbs = GetOpenDatabasesForOrigin(origin_url);

[jsbell, 2013/12/20 00:24:42]

GetOpenDatabasesForOrigin is documented in the header as "for diagnostics only"
(since it's an O(N) scan). Either we're accepting that and the comment is now
wrong, or we should consider if we want to maintain a multimap as well.

[cmumford, 2013/12/20 18:09:26]

I've got the multimap code written in another branch. Are we typically dealing
with enough connections to justify the added complexity? Let me know and I'll
bring the multimap in. At a minimum I need to fix the comment.

[jsbell, 2013/12/20 18:22:56]

You're probably right that our numbers are typically low. So adjusting the
comments is probably fine, maybe add a // TODO(cmumford): Consider adding a
multimap here.

+  std::vector<IndexedDBDatabase*>::iterator i;

[jsbell, 2013/12/20 00:24:42]

Nit: change i to it or iter

[cmumford, 2013/12/20 18:09:26]

Done.

+  for (i = dbs.begin(); i != dbs.end(); ++i) {

[jsbell, 2013/12/20 00:24:42]

Nit: No need for braces. The iterator initialization can also be done inside the
for clause to scope the iterator.

[cmumford, 2013/12/20 18:09:26]

Done.

+    (*i)->ForceClose();
+  }
+
   if (backing_store_map_.find(origin_url) != backing_store_map_.end())
     ReleaseBackingStore(origin_url, true /* immediate */);
 }