Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: runtime/vm/isolate.cc

Issue 93873015: - Remove the reply_port from the VM internal message object. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/dart_entry.cc ('k') | runtime/vm/message.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/isolate.h" 5 #include "vm/isolate.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "platform/json.h" 9 #include "platform/json.h"
10 #include "lib/mirrors.h" 10 #include "lib/mirrors.h"
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 // In the case that the message originated locally, which is 136 // In the case that the message originated locally, which is
137 // always true for now, then this should never occur. 137 // always true for now, then this should never occur.
138 UNREACHABLE(); 138 UNREACHABLE();
139 } 139 }
140 140
141 Instance& msg = Instance::Handle(); 141 Instance& msg = Instance::Handle();
142 msg ^= msg_obj.raw(); // Can't use Instance::Cast because may be null. 142 msg ^= msg_obj.raw(); // Can't use Instance::Cast because may be null.
143 143
144 bool success = true; 144 bool success = true;
145 if (message->IsOOB()) { 145 if (message->IsOOB()) {
146 Service::HandleServiceMessage(isolate_, message->reply_port(), msg); 146 Service::HandleServiceMessage(isolate_, msg);
147 } else { 147 } else {
148 const Object& result = Object::Handle( 148 const Object& result = Object::Handle(
149 DartLibraryCalls::HandleMessage( 149 DartLibraryCalls::HandleMessage(receive_port, msg));
150 receive_port, message->reply_port(), msg));
151 if (result.IsError()) { 150 if (result.IsError()) {
152 success = ProcessUnhandledException(msg, Error::Cast(result)); 151 success = ProcessUnhandledException(msg, Error::Cast(result));
153 } else { 152 } else {
154 ASSERT(result.IsNull()); 153 ASSERT(result.IsNull());
155 } 154 }
156 } 155 }
157 delete message; 156 delete message;
158 return success; 157 return success;
159 } 158 }
160 159
(...skipping 960 matching lines...) Expand 10 before | Expand all | Expand 10 after
1121 return func.raw(); 1120 return func.raw();
1122 } 1121 }
1123 1122
1124 1123
1125 void IsolateSpawnState::Cleanup() { 1124 void IsolateSpawnState::Cleanup() {
1126 SwitchIsolateScope switch_scope(isolate()); 1125 SwitchIsolateScope switch_scope(isolate());
1127 Dart::ShutdownIsolate(); 1126 Dart::ShutdownIsolate();
1128 } 1127 }
1129 1128
1130 } // namespace dart 1129 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/dart_entry.cc ('k') | runtime/vm/message.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698