Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 93873007: Fix parameter passing in callback store ics on arm (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/cctest/test-accessors.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 893 matching lines...) Expand 10 before | Expand all | Expand 10 after
904 ASSERT(!receiver.is(scratch)); 904 ASSERT(!receiver.is(scratch));
905 905
906 typedef FunctionCallbackArguments FCA; 906 typedef FunctionCallbackArguments FCA;
907 const int stack_space = kFastApiCallArguments + argc + 1; 907 const int stack_space = kFastApiCallArguments + argc + 1;
908 // Assign stack space for the call arguments. 908 // Assign stack space for the call arguments.
909 __ sub(sp, sp, Operand(stack_space * kPointerSize)); 909 __ sub(sp, sp, Operand(stack_space * kPointerSize));
910 // Write holder to stack frame. 910 // Write holder to stack frame.
911 __ str(receiver, MemOperand(sp, FCA::kHolderIndex * kPointerSize)); 911 __ str(receiver, MemOperand(sp, FCA::kHolderIndex * kPointerSize));
912 // Write receiver to stack frame. 912 // Write receiver to stack frame.
913 int index = stack_space - 1; 913 int index = stack_space - 1;
914 __ str(receiver, MemOperand(sp, index * kPointerSize)); 914 __ str(receiver, MemOperand(sp, index-- * kPointerSize));
915 // Write the arguments to stack frame. 915 // Write the arguments to stack frame.
916 for (int i = 0; i < argc; i++) { 916 for (int i = 0; i < argc; i++) {
917 ASSERT(!receiver.is(values[i])); 917 ASSERT(!receiver.is(values[i]));
918 ASSERT(!scratch.is(values[i])); 918 ASSERT(!scratch.is(values[i]));
919 __ str(receiver, MemOperand(sp, index-- * kPointerSize)); 919 __ str(values[i], MemOperand(sp, index-- * kPointerSize));
920 } 920 }
921 921
922 GenerateFastApiDirectCall(masm, optimization, argc, true); 922 GenerateFastApiDirectCall(masm, optimization, argc, true);
923 } 923 }
924 924
925 925
926 class CallInterceptorCompiler BASE_EMBEDDED { 926 class CallInterceptorCompiler BASE_EMBEDDED {
927 public: 927 public:
928 CallInterceptorCompiler(CallStubCompiler* stub_compiler, 928 CallInterceptorCompiler(CallStubCompiler* stub_compiler,
929 const ParameterCount& arguments, 929 const ParameterCount& arguments,
(...skipping 1961 matching lines...) Expand 10 before | Expand all | Expand 10 after
2891 // ----------------------------------- 2891 // -----------------------------------
2892 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 2892 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
2893 } 2893 }
2894 2894
2895 2895
2896 #undef __ 2896 #undef __
2897 2897
2898 } } // namespace v8::internal 2898 } } // namespace v8::internal
2899 2899
2900 #endif // V8_TARGET_ARCH_ARM 2900 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | test/cctest/test-accessors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698