Login interstitial should always replace existing interstitials.

Login interstitial should always replace existing interstitials.

The last committed URL check isn't sufficient in certain scenarios.
This CL ensures that login interstitials always replace any existing
interstitial.

BUG=458972
Committed: https://crrev.com/42992bcd1fa2fd0813eacc133bd8315c687232af
Cr-Commit-Position: refs/heads/master@{#319686}

[meacer, 2015-03-03 19:58:42]

meacer@chromium.org changed reviewers:
+ msw@chromium.org

[meacer, 2015-03-03 19:58:43]

msw: Can you PTAL? Thanks.

[msw, 2015-03-03 20:44:42]

Are we sure login should replace SecurityInterstitialPage, etc.? Someone more
familiar with this area should review...

[meacer, 2015-03-03 21:19:31]

meacer@chromium.org changed reviewers:
+ creis@chromium.org

[meacer, 2015-03-03 21:19:32]

creis: Can you PTAL too?

We will only replace on a new navigation. In other words, the tab should have
already navigated away from the url that triggered the security interstitial.

[Charlie Reis, 2015-03-04 22:52:02]

LGTM as long as the old interstitial is properly canceled (which should cancel
the in-progress network request).

https://codereview.chromium.org/938713003/diff/20001/chrome/browser/ui/login/...
File chrome/browser/ui/login/login_prompt.cc (right):

https://codereview.chromium.org/938713003/diff/20001/chrome/browser/ui/login/...
chrome/browser/ui/login/login_prompt.cc:559: new
LoginInterstitialDelegate(parent_contents,
Does this automatically cancel any existing interstitial?  If so, let's mention
that in the comment on line 558.

[meacer, 2015-03-04 23:09:02]

https://codereview.chromium.org/938713003/diff/20001/chrome/browser/ui/login/...
File chrome/browser/ui/login/login_prompt.cc (right):

https://codereview.chromium.org/938713003/diff/20001/chrome/browser/ui/login/...
chrome/browser/ui/login/login_prompt.cc:559: new
LoginInterstitialDelegate(parent_contents,
On 2015/03/04 22:52:02, Charlie Reis wrote:
> Does this automatically cancel any existing interstitial?  If so, let's
mention
> that in the comment on line 558.

It cancels the existing interstitial. Added a comment.

[meacer, 2015-03-06 21:44:53]

msw: Ping now that creis@ took another look :)

[msw, 2015-03-06 22:22:53]

rubber stamp lgtm

[meacer, 2015-03-06 22:45:25]

Thanks.

[meacer, 2015-03-06 22:45:29]

The CQ bit was checked by meacer@chromium.org

[meacer, 2015-03-06 22:45:29]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/938713003/revert#ps40001
(title: "creis comment")

[commit-bot: I haz the power, 2015-03-06 22:47:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/938713003/40001

[commit-bot: I haz the power, 2015-03-07 00:49:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-07 00:49:46]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
Timed out jobs are not retried to avoid causing additional load on the builders
with large pending queues.

[meacer, 2015-03-07 05:25:07]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2015-03-07 05:26:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/938713003/40001

[commit-bot: I haz the power, 2015-03-07 07:26:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-07 07:26:46]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
Timed out jobs are not retried to avoid causing additional load on the builders
with large pending queues.

[meacer, 2015-03-09 17:22:24]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2015-03-09 17:23:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/938713003/40001

[commit-bot: I haz the power, 2015-03-09 18:12:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-09 18:13:49]

Patchset 3 (id:??) landed as
https://crrev.com/42992bcd1fa2fd0813eacc133bd8315c687232af
Cr-Commit-Position: refs/heads/master@{#319686}