Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: src/isolate.cc

Issue 938693002: Fix sampling of V8.DetachedContextAgeInGC histogram. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 8c3fce930ed6732c281a46ed83cd30a915a52b39..7319af41c181d6ea8f89251e9f5e1132a97c28b8 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2598,9 +2598,8 @@ void Isolate::CheckDetachedContextsAfterGC() {
detached_contexts->set(new_length, Smi::FromInt(mark_sweeps + 1));
detached_contexts->set(new_length + 1, cell);
new_length += 2;
- } else {
- counters()->detached_context_age_in_gc()->AddSample(mark_sweeps);
ulan 2015/02/18 13:14:33 We need to sample all detached contexts, not only
}
+ counters()->detached_context_age_in_gc()->AddSample(mark_sweeps + 1);
}
if (FLAG_trace_detached_contexts) {
PrintF("%d detached contexts are collected out of %d\n",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698