Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 938693002: Fix sampling of V8.DetachedContextAgeInGC histogram. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix sampling of V8.DetachedContextAgeInGC histogram. BUG= Committed: https://crrev.com/161161900befb8f4447e6d76a19fa9e924314143 Cr-Commit-Position: refs/heads/master@{#26719}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/isolate.cc View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL https://codereview.chromium.org/938693002/diff/1/src/isolate.cc File src/isolate.cc (left): https://codereview.chromium.org/938693002/diff/1/src/isolate.cc#oldcode2602 src/isolate.cc:2602: counters()->detached_context_age_in_gc()->AddSample(mark_sweeps); We need to sample all detached contexts, ...
5 years, 10 months ago (2015-02-18 13:14:33 UTC) #2
Hannes Payer (out of office)
LGTM
5 years, 10 months ago (2015-02-18 13:27:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938693002/1
5 years, 10 months ago (2015-02-18 13:29:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 13:50:46 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 13:51:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/161161900befb8f4447e6d76a19fa9e924314143
Cr-Commit-Position: refs/heads/master@{#26719}

Powered by Google App Engine
This is Rietveld 408576698