Issue 938683002: Add --single-threaded flag that disables background threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 938683002: Add --single-threaded flag that disables background threads. (Closed)

Created:
5 years, 10 months ago by ulan

Modified:
5 years, 10 months ago

Reviewers:
Yang

CC:
v8-dev, thomaspark_google.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Add --single-threaded flag that disables background threads. BUG=

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -12 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/heap/mark-compact.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/isolate.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/optimizing-compiler-thread.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A +	test/mjsunit/single-threaded.js	View	1 chunk	+13 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ulan

PTAL. This flag is useful for V8 embedders and protects them from changes in GC/compiler ...

5 years, 10 months ago (2015-02-18 11:23:13 UTC) #2

Yang

On 2015/02/18 11:24:18, ulan wrote: > [+Thomas] This can be achieved just as easily by ...

5 years, 10 months ago (2015-02-18 11:26:40 UTC) #4

ulan

5 years, 10 months ago (2015-02-18 12:14:23 UTC) #5

On 2015/02/18 11:26:40, Yang wrote:
> On 2015/02/18 11:24:18, ulan wrote:
> > [+Thomas]
> 
> This can be achieved just as easily by using
> ResourceConstraints.set_max_available_threads, which is designed for this use
> case. Why do we need an second way to do this?

Right, that is better :)

At the moment the max_available_threads is ignored in GC and platform thread
pool. I uploaded a CL that fixes the GC part:
https://codereview.chromium.org/916103005/

Closing this CL.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages