Use click event for search field cancel button

Use click event for search field cancel button

The previous behavior was to select all on mouse down and clear on mouse up. This matched the Cocoa NSSearchField behavior.
On Android the button may be so small users couldn't tap it reliably and only mousedown would fire.

BUG=329326
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170202

[tkent, 2014-01-07 13:33:52]

https://codereview.chromium.org/93863007/diff/1/Source/core/html/shadow/TextC...
File Source/core/html/shadow/TextControlInnerElements.cpp (right):

https://codereview.chromium.org/93863007/diff/1/Source/core/html/shadow/TextC...
Source/core/html/shadow/TextControlInnerElements.cpp:236: #if OS(ANDROID)
We don't want to add platform-#if in core.
Can we
 * handle touch events and ignore synthetic mouse events, or
 * just remove mouse capturing and repond to click event instead of mousedown?

[keishi, 2014-01-08 04:01:08]

On 2014/01/07 13:33:52, tkent wrote:
>
https://codereview.chromium.org/93863007/diff/1/Source/core/html/shadow/TextC...
> File Source/core/html/shadow/TextControlInnerElements.cpp (right):
> 
>
https://codereview.chromium.org/93863007/diff/1/Source/core/html/shadow/TextC...
> Source/core/html/shadow/TextControlInnerElements.cpp:236: #if OS(ANDROID)
> We don't want to add platform-#if in core.
> Can we
>  * handle touch events and ignore synthetic mouse events, or
>  * just remove mouse capturing and repond to click event instead of mousedown?

I think we can just use click instead of mousedown/up. It is how IE11 and Win8.1
works.

[tkent, 2014-01-08 04:04:56]

On 2014/01/08 04:01:08, keishi1 wrote:
> I think we can just use click instead of mousedown/up. It is how IE11 and
Win8.1
> works.

It sounds reasonable.

[tkent, 2014-03-13 01:59:57]

lgtm

[commit-bot: I haz the power, 2014-03-13 02:00:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keishi@chromium.org/93863007/60001

[commit-bot: I haz the power, 2014-03-13 02:00:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 02:00:26]

Failed to apply patch for Source/core/html/shadow/TextControlInnerElements.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/html/shadow/TextControlInnerElements.cpp
  Hunk #1 FAILED at 234.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/html/shadow/TextControlInnerElements.cpp.rej

Patch:       Source/core/html/shadow/TextControlInnerElements.cpp
Index: Source/core/html/shadow/TextControlInnerElements.cpp
diff --git a/Source/core/html/shadow/TextControlInnerElements.cpp
b/Source/core/html/shadow/TextControlInnerElements.cpp
index
5570359abb5ad374f94924769a6bf38d0228077c..c440c6dcb67c64997288b5eae6ea6a3c1b387850
100644
--- a/Source/core/html/shadow/TextControlInnerElements.cpp
+++ b/Source/core/html/shadow/TextControlInnerElements.cpp
@@ -234,31 +234,11 @@ void
SearchFieldCancelButtonElement::defaultEventHandler(Event* event)
         return;
     }
 
-    if (event->type() == EventTypeNames::mousedown && event->isMouseEvent() &&
toMouseEvent(event)->button() == LeftButton) {
-        if (renderer() && renderer()->visibleToHitTesting()) {
-            if (Frame* frame = document().frame()) {
-                frame->eventHandler().setCapturingMouseEventsNode(this);
-                m_capturing = true;
-            }
-        }
-        input->focus();
-        input->select();
+    if (event->type() == EventTypeNames::click && event->isMouseEvent() &&
toMouseEvent(event)->button() == LeftButton) {
+        input->setValueForUser("");
+        input->onSearch();
         event->setDefaultHandled();
     }
-    if (event->type() == EventTypeNames::mouseup && event->isMouseEvent() &&
toMouseEvent(event)->button() == LeftButton) {
-        if (m_capturing) {
-            if (Frame* frame = document().frame()) {
-                frame->eventHandler().setCapturingMouseEventsNode(0);
-                m_capturing = false;
-            }
-            if (hovered()) {
-                String oldValue = input->value();
-                input->setValueForUser("");
-                input->onSearch();
-                event->setDefaultHandled();
-            }
-        }
-    }
 
     if (!event->defaultHandled())
         HTMLDivElement::defaultEventHandler(event);

[keishi, 2014-03-27 19:08:08]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-03-27 19:08:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keishi@chromium.org/93863007/120001

[commit-bot: I haz the power, 2014-03-27 20:16:52]

Change committed as 170202