Regression(r164102): CSS Selector queries on duplicate ids match non-descendant elements

Regression(r164102): CSS Selector queries on duplicate ids match non-descendant elements

After r164102, CSS Selector queries on duplicate ids match non-descendant
elements. It returns ALL elements with the given identifier, without checking
that these are descendant of the scope Element.

This CL adds the missing scope check.

BUG=331692
TEST=fast/dom/SelectorAPI/duplicate-id-scope.html
R=esprehn, abarth

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164484

[Inactive, 2014-01-05 20:29:48]

Sorry I missed that in my earlier patch.

[Inactive, 2014-01-05 20:46:33]

https://codereview.chromium.org/93863004/diff/1/Source/core/dom/SelectorQuery...
File Source/core/dom/SelectorQuery.cpp (right):

https://codereview.chromium.org/93863004/diff/1/Source/core/dom/SelectorQuery...
Source/core/dom/SelectorQuery.cpp:468: if (!(isTreeScopeRoot(rootNode) ||
element->isDescendantOf(&rootNode)))
FYI, I am planning on working on getting rid of the code duplication between
executeQueryFirst() / executeQueryAll() in a follow-up patch.

[esprehn, 2014-01-05 21:36:55]

Lgtm

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-05 21:51:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/93863004/1

[commit-bot: I haz the power, 2014-01-06 04:23:55]

Change committed as 164484