Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: sky/engine/core/app/AbstractModule.h

Issue 938623005: Allow multiple dart <script> tags in .sky files (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: All works! Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/app/AbstractModule.h
diff --git a/sky/engine/core/app/AbstractModule.h b/sky/engine/core/app/AbstractModule.h
index dcc6c77414b4bbf09ae11e70c6116f65e058e591..c3a9b551ff79a5c10f3d218e1c5f3e227cc74dba 100644
--- a/sky/engine/core/app/AbstractModule.h
+++ b/sky/engine/core/app/AbstractModule.h
@@ -13,6 +13,19 @@
namespace blink {
class Application;
+class LibraryEntry {
+ public:
+ LibraryEntry(PassRefPtr<DartValue> library, TextPosition position)
+ : dart_library_(library), text_position_(position) {}
+
+ DartValue* library() { return dart_library_.get(); }
+ const TextPosition& position() { return text_position_; }
+
+ private:
+ RefPtr<DartValue> dart_library_;
+ TextPosition text_position_;
+};
+
class AbstractModule : public RefCounted<AbstractModule>,
public EventTargetWithInlineData,
public ContextLifecycleObserver {
@@ -25,9 +38,10 @@ class AbstractModule : public RefCounted<AbstractModule>,
virtual bool isApplication() const { return false; }
- void set_library(RefPtr<DartValue> library) { library_ = library; }
+ String UrlForLibraryAt(TextPosition);
- DartValue* library() const { return library_.get(); }
+ void AddLibrary(RefPtr<DartValue> library, TextPosition position);
+ const Vector<LibraryEntry>& libraries() const { return libraries_; }
protected:
AbstractModule(ExecutionContext*, PassRefPtr<Document>, const String& url);
@@ -39,7 +53,7 @@ class AbstractModule : public RefCounted<AbstractModule>,
RefPtr<Document> document_;
String url_;
- RefPtr<DartValue> library_;
+ Vector<LibraryEntry> libraries_;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698