Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(286)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: sky/tests/modules/dart-imports-loader-interaction.sky
Issue
938623005
:
Allow multiple dart <script> tags in .sky files (Closed)
Base URL: git@github.com:domokit/mojo.git@master
Patch Set: All works!
Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
sky/engine/core/BUILD.gn
sky/engine/core/app/AbstractModule.h
sky/engine/core/app/AbstractModule.cpp
sky/engine/core/html/parser/HTMLDocumentParser.h
sky/engine/core/html/parser/HTMLDocumentParser.cpp
sky/engine/core/html/parser/HTMLScriptRunner.h
sky/engine/core/html/parser/HTMLScriptRunner.cpp
sky/engine/core/script/dart_controller.h
sky/engine/core/script/dart_controller.cc
sky/engine/core/script/dart_loader.cc
sky/tests/modules/dart-imports-loader-interaction.sky
sky/tests/modules/dart-imports-loader-interaction-expected.txt
sky/tests/modules/multiple-scripts.sky
sky/tests/modules/multiple-scripts-expected.txt
sky/tests/modules/multiple-scripts-import.sky
sky/tests/modules/multiple-scripts-import-expected.txt
sky/tests/modules/resources/dart-import.dart
sky/tests/modules/resources/multiple-scripts-child.sky
sky/tests/modules/resources/with-dart-import.sky
View unified diff
|
Download patch
« sky/engine/core/script/dart_controller.cc
('K') |
« sky/engine/core/script/dart_loader.cc
('k') |
sky/tests/modules/dart-imports-loader-interaction-expected.txt »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<import src='resources/with-dart-import.sky' as='test'></import>
2
<script>
3
import "dart:sky.internals" as internals;
4
5
void main() {
6
// The HTMLImportsLoader used to think with-dart-import load completed
7
// and did not know about with-dart-import having dart import statements
8
// which had made the load/execution of the script asynchronous.
9
String result = test.didInit ? "PASS" : "FAIL";
10
internals.notifyTestComplete(result);
11
}
12
</script>
OLD
NEW
« sky/engine/core/script/dart_controller.cc
('K') |
« sky/engine/core/script/dart_loader.cc
('k') |
sky/tests/modules/dart-imports-loader-interaction-expected.txt »
('j') |
no next file with comments »
Issue 938623005: Allow multiple dart <script> tags in .sky files (Closed)
Created 5 years, 10 months ago by eseidel
Modified 5 years, 10 months ago
Reviewers: abarth-chromium
Base URL: git@github.com:domokit/mojo.git@master
Comments: 8
This is Rietveld
408576698
Chromium Code Reviews
Issue 938623005:
Allow multiple dart <script> tags in .sky files (Closed)
Base URL: git@github.com:domokit/mojo.git@master