chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js - Issue 938623003: Fix ChromeVox next tests to fail instead of timing out where applicable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js

Issue 938623003: Fix ChromeVox next tests to fail instead of timing out where applicable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify async callback handling in the tests. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js

diff --git a/chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js b/chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js

index 3308992120cd8b9da4a5ad9930711d707f739dd7..3f32d0ca400195ba699af41f9c70f0463edc5d2d 100644

--- a/chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js

+++ b/chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js

@@ -62,10 +62,11 @@ MockTts.prototype = {

/**

- * Finishes expectations and calls testDone.

+ * Finishes expectations and calls {@code callback} afterwards.

+ * @param {Function} callback

- finishExpectations: function() {

- this.expectSpeechAfter('', testDone);

+ finishExpectations: function(callback) {

+ this.expectSpeechAfter('', callback);

/**

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js ('k') | no next file » | no next file with comments »