chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs - Issue 938623003: Fix ChromeVox next tests to fail instead of timing out where applicable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

Issue 938623003: Fix ChromeVox next tests to fail instead of timing out where applicable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify async callback handling in the tests. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

index 669c605e6d2b2e752a3108ce65ca6168bbf45d56..5f0457578327c39220f41339c52a54a3bd93a93f 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

@@ -10,7 +10,9 @@ GEN_INCLUDE(['../../testing/chromevox_next_e2e_test_base.js']);

* @constructor

* @extends {ChromeVoxNextE2ETest}

-function CursorsTest() {}

+function CursorsTest() {

+ ChromeVoxNextE2ETest.call(this);

CursorsTest.prototype = {

__proto__: ChromeVoxNextE2ETest.prototype,

@@ -107,13 +109,11 @@ CursorsTest.prototype = {

if (!opt_testType || opt_testType == this.CURSOR) {

var cursor = new cursors.Cursor(start, 0);

this.cursorMoveAndAssert(cursor, moves);

- testDone();

} else if (opt_testType == this.RANGE) {

var range = new cursors.Range(cursor, cursor);

this.rangeMoveAndAssert(range, moves);

- testDone();

}

- }.bind(this));

+ });

simpleDoc: function() {/*!