Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5615)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs

Issue 938623003: Fix ChromeVox next tests to fail instead of timing out where applicable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplify async callback handling in the tests. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs
index 90d76a81011941cbfc8d4b22bd0c372f802a7001..2c75b9fc26bea3c972fe4f6d44892d6770432128 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs
@@ -10,7 +10,9 @@ GEN_INCLUDE(['../../testing/chromevox_next_e2e_test_base.js']);
* @constructor
* @extends {ChromeVoxE2ETestBase}
*/
-function AutomationUtilE2ETest() {}
+function AutomationUtilE2ETest() {
+ ChromeVoxNextE2ETest.call(this);
+}
AutomationUtilE2ETest.prototype = {
__proto__: ChromeVoxNextE2ETest.prototype,
@@ -27,16 +29,14 @@ AutomationUtilE2ETest.prototype = {
};
TEST_F('AutomationUtilE2ETest', 'GetAncestors', function() {
- this.runWithLoadedTree(this.basicDoc,
- function(root) {
- var expectedLength = 1;
- while (root) {
- var ancestors = AutomationUtil.getAncestors(root);
- assertEquals(expectedLength++, ancestors.length);
- root = root.firstChild;
- }
- testDone();
- }.bind(this));
+ this.runWithLoadedTree(this.basicDoc, function(root) {
+ var expectedLength = 1;
+ while (root) {
+ var ancestors = AutomationUtil.getAncestors(root);
+ assertEquals(expectedLength++, ancestors.length);
+ root = root.firstChild;
+ }
+ });
});
TEST_F('AutomationUtilE2ETest', 'GetUniqueAncestors', function() {
@@ -78,8 +78,7 @@ TEST_F('AutomationUtilE2ETest', 'GetUniqueAncestors', function() {
assertEquals(
1, AutomationUtil.getUniqueAncestors(leftmost, leftmost).length);
- testDone();
- }.bind(this));
+ });
});
TEST_F('AutomationUtilE2ETest', 'GetDirection', function() {
@@ -99,6 +98,5 @@ TEST_F('AutomationUtilE2ETest', 'GetDirection', function() {
assertEquals(Dir.BACKWARD, AutomationUtil.getDirection(right, left));
assertEquals(Dir.FORWARD, AutomationUtil.getDirection(left, right));
- testDone();
- }.bind(this));
+ });
});

Powered by Google App Engine
This is Rietveld 408576698