chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands_test.unitjs - Issue 938623003: Fix ChromeVox next tests to fail instead of timing out where applicable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands_test.unitjs

Issue 938623003: Fix ChromeVox next tests to fail instead of timing out where applicable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify async callback handling in the tests. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager_test.unitjs ('k') | chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands_test.unitjs

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands_test.unitjs b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands_test.unitjs

index cb122e6fb95e5629e34c1ee8b3dff723f9173d39..8459a35dca5459b6f073480765c4c6c2d098c91e 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands_test.unitjs

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands_test.unitjs

@@ -10,7 +10,9 @@ GEN_INCLUDE(['../../testing/chromevox_unittest_base.js']);

* @constructor

* @extends {ChromeVoxUnitTestBase}

-function CvoxUserCommandsUnitTest() {}

+function CvoxUserCommandsUnitTest() {

+ ChromeVoxUnitTestBase.call(this);

CvoxUserCommandsUnitTest.prototype = {

__proto__: ChromeVoxUnitTestBase.prototype,

@@ -57,7 +59,6 @@ TEST_F('CvoxUserCommandsUnitTest', 'TabHandling', function() {

var id = document.activeElement.nextSibling.id;

assertEquals('foo', id);

});

- this.waitForCalm(testDone);

});

/**