chrome/browser/resources/chromeos/chromevox/braille/liblouis.js - Issue 938623003: Fix ChromeVox next tests to fail instead of timing out where applicable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/braille/liblouis.js

Issue 938623003: Fix ChromeVox next tests to fail instead of timing out where applicable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify async callback handling in the tests. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager_test.extjs ('k') | chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/braille/liblouis.js

diff --git a/chrome/browser/resources/chromeos/chromevox/braille/liblouis.js b/chrome/browser/resources/chromeos/chromevox/braille/liblouis.js

index efa3e11ed8365cab55d5ed172334007a4e37f342..2d66b84de3d1de4a99338fab1456b9c50a63a7cc 100644

--- a/chrome/browser/resources/chromeos/chromevox/braille/liblouis.js

+++ b/chrome/browser/resources/chromeos/chromevox/braille/liblouis.js

@@ -235,6 +235,7 @@ cvox.LibLouis.Translator = function(instance, tableNames) {

cvox.LibLouis.Translator.prototype.translate = function(text, callback) {

if (!this.instance_.isAttached()) {

callback(null /*cells*/, null /*textToBraille*/, null /*brailleToText*/);

+ return;

}

var message = { 'table_names': this.tableNames_, 'text': text };

this.instance_.rpc_('Translate', message, function(reply) {

@@ -268,6 +269,7 @@ cvox.LibLouis.Translator.prototype.backTranslate =

function(cells, callback) {

if (!this.instance_.isAttached()) {

callback(null /*text*/);

+ return;

}

if (cells.byteLength == 0) {

// liblouis doesn't handle empty input, so handle that trivially