Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js

Issue 938623003: Fix ChromeVox next tests to fail instead of timing out where applicable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js
diff --git a/chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js b/chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js
index e432a998de5f9d711f04ff24f136c4ef8509eeee..893893422f561f78041d3cf682e1951cb98ba190 100644
--- a/chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js
+++ b/chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js
@@ -19,21 +19,13 @@ function ChromeVoxNextE2ETest() {}
ChromeVoxNextE2ETest.prototype = {
__proto__: ChromeVoxE2ETest.prototype,
- /**
- * This method is called without |this| bound to an instance of
- * ChromeVoxNextE2ETest.
- * @override
- */
- testGenCppIncludes: function() {
- ChromeVoxE2ETest.prototype.testGenCppIncludes.call(this);
- GEN('#include "base/command_line.h"');
David Tseng 2015/02/18 17:27:40 Thanks for removing this.
- },
-
runWithAutomation: function(doc, callback) {
this.runWithDocument(doc, function() {
- chrome.automation.getTree(function(root) {
- callback(root);
- }.bind(this));
+ chrome.automation.getTree(this.continueTest(
+ WhenTestDone.ASSERT,
+ function(root) {
+ callback(root);
+ }.bind(this)));
David Tseng 2015/02/18 17:27:40 Doesn't seem like a good place to assume the calle
}.bind(this));
}
};
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698