Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js

Issue 938623003: Fix ChromeVox next tests to fail instead of timing out where applicable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Include test fixture. 5 // Include test fixture.
6 GEN_INCLUDE(['chrome/browser/resources/chromeos/chromevox/testing/' + 6 GEN_INCLUDE(['chrome/browser/resources/chromeos/chromevox/testing/' +
7 'chromevox_e2e_test_base.js']); 7 'chromevox_e2e_test_base.js']);
8 8
9 /** 9 /**
10 * Base test fixture for ChromeVox Next end to end tests. 10 * Base test fixture for ChromeVox Next end to end tests.
11 * 11 *
12 * These tests are identical to ChromeVoxE2ETests except for performing the 12 * These tests are identical to ChromeVoxE2ETests except for performing the
13 * necessary setup to run ChromeVox Next. 13 * necessary setup to run ChromeVox Next.
14 * @constructor 14 * @constructor
15 * @extends {ChromeVoxE2ETest} 15 * @extends {ChromeVoxE2ETest}
16 */ 16 */
17 function ChromeVoxNextE2ETest() {} 17 function ChromeVoxNextE2ETest() {}
18 18
19 ChromeVoxNextE2ETest.prototype = { 19 ChromeVoxNextE2ETest.prototype = {
20 __proto__: ChromeVoxE2ETest.prototype, 20 __proto__: ChromeVoxE2ETest.prototype,
21 21
22 /**
23 * This method is called without |this| bound to an instance of
24 * ChromeVoxNextE2ETest.
25 * @override
26 */
27 testGenCppIncludes: function() {
28 ChromeVoxE2ETest.prototype.testGenCppIncludes.call(this);
29 GEN('#include "base/command_line.h"');
David Tseng 2015/02/18 17:27:40 Thanks for removing this.
30 },
31
32 runWithAutomation: function(doc, callback) { 22 runWithAutomation: function(doc, callback) {
33 this.runWithDocument(doc, function() { 23 this.runWithDocument(doc, function() {
34 chrome.automation.getTree(function(root) { 24 chrome.automation.getTree(this.continueTest(
35 callback(root); 25 WhenTestDone.ASSERT,
36 }.bind(this)); 26 function(root) {
27 callback(root);
28 }.bind(this)));
David Tseng 2015/02/18 17:27:40 Doesn't seem like a good place to assume the calle
37 }.bind(this)); 29 }.bind(this));
38 } 30 }
39 }; 31 };
OLDNEW
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698