Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 938603004: Cleanup: Remove chrome_perf_test target. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang, dtu, sky, tonyg, ccameron
CC:
chromium-reviews, Lei Zhang, tonyg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove chrome_perf_test target. And all the unused files under chrome/test/perf/. BUG=None TEST=everything still works + trybots R=sky@chromium.org Committed: https://crrev.com/3849bd2b775e9fa55dc43412b17058ff0c1762f9 Cr-Commit-Position: refs/heads/master@{#319548}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : REBASE #

Patch Set 4 : add missing testing/perf/perf_test.gyp dependency to browser_tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -541 lines) Patch
M chrome/chrome_tests.gypi View 1 2 3 5 chunks +1 line, -5 lines 0 comments Download
D chrome/test/perf/browser_perf_test.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/test/perf/browser_perf_test.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/test/perf/perf_test.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/test/perf/perf_test.cc View 1 chunk +0 lines, -409 lines 0 comments Download
D chrome/test/perf/perf_test.gyp View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 32 (11 generated)
tfarina
Nathaniel, could you review this to me? Lei has reviewed my previous cleanups patches in ...
5 years, 10 months ago (2015-02-19 02:30:18 UTC) #2
tfarina
-nduca! +sky! Scott, could you review this to me as chrome/OWNERS? Thanks!
5 years, 10 months ago (2015-02-21 17:06:47 UTC) #4
sky
I don't know anything about this test. Who added it?
5 years, 10 months ago (2015-02-23 15:50:36 UTC) #5
tfarina
Scott, looks like the gyp file was added in https://chromium.googlesource.com/chromium/src/+/498160bba533677d2e07b863e762b2e36e416f2f while perf_test.cc was added in ...
5 years, 10 months ago (2015-02-23 20:32:03 UTC) #6
tfarina
Scott, ping? Do you feel comfortable approving this? Do you prefer I send this to ...
5 years, 10 months ago (2015-02-24 18:36:11 UTC) #7
sky
On 2015/02/24 18:36:11, tfarina wrote: > Scott, ping? > > Do you feel comfortable approving ...
5 years, 10 months ago (2015-02-24 19:49:49 UTC) #8
tonyg
lgtm
5 years, 10 months ago (2015-02-25 22:17:26 UTC) #10
tfarina
Scott, could you approve this? I think John does not work on Chromium anymore.
5 years, 9 months ago (2015-03-02 23:42:11 UTC) #11
sky
On 2015/03/02 23:42:11, tfarina wrote: > Scott, could you approve this? I think John does ...
5 years, 9 months ago (2015-03-03 03:24:57 UTC) #12
jbates
On 2015/03/03 03:24:57, sky wrote: > On 2015/03/02 23:42:11, tfarina wrote: > > Scott, could ...
5 years, 9 months ago (2015-03-03 04:18:13 UTC) #14
ccameron
Sorry, I don't recognize this -- adding dtu (former OWNER in the patch).
5 years, 9 months ago (2015-03-04 18:24:33 UTC) #16
dtu
lgtm
5 years, 9 months ago (2015-03-05 23:24:05 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938603004/20001
5 years, 9 months ago (2015-03-05 23:24:53 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/2683)
5 years, 9 months ago (2015-03-05 23:28:34 UTC) #21
tfarina
Scott, could you approve this now?
5 years, 9 months ago (2015-03-06 18:50:51 UTC) #22
sky
LGTM
5 years, 9 months ago (2015-03-06 22:48:43 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938603004/60001
5 years, 9 months ago (2015-03-07 00:12:10 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 02:13:39 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938603004/60001
5 years, 9 months ago (2015-03-07 03:05:05 UTC) #30
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-07 03:07:10 UTC) #31
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 03:07:59 UTC) #32
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3849bd2b775e9fa55dc43412b17058ff0c1762f9
Cr-Commit-Position: refs/heads/master@{#319548}

Powered by Google App Engine
This is Rietveld 408576698